Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress exportString tests that fail with CHPL_TARGET_COMPILER=cray-prgenv-cray #13534

Merged

Conversation

dlongnecke-cray
Copy link
Contributor

This PR suppresses two tests that currently fail in a cray-xc environment with CHPL_TARGET_COMPILER=cray-prgenv-cray. The Chapel type c_ptr(c_char) currently maps to int8_t* on most systems, which causes the GNU compiler to emit warnings that can be suppressed with -Wno-pointer-sign. There is no equivalent for Cray CC, so we should suppress these tests until #6041 is resolved.

@dlongnecke-cray dlongnecke-cray self-assigned this Jul 24, 2019
@dlongnecke-cray dlongnecke-cray requested a review from gbtitus July 24, 2019 00:34
@dlongnecke-cray
Copy link
Contributor Author

@gbtitus, I am unsure of how to replicate the testing environment listed below:

    CHPL_HOST_PLATFORM: cray-xc
    CHPL_HOST_COMPILER: gnu
    CHPL_HOST_ARCH: x86_64
    CHPL_TARGET_PLATFORM: cray-xc *
    CHPL_TARGET_COMPILER: cray-prgenv-cray
    CHPL_TARGET_ARCH: x86_64
    CHPL_TARGET_CPU: ivybridge
    CHPL_LOCALE_MODEL: flat
    CHPL_COMM: none *
    CHPL_TASKS: qthreads
    CHPL_LAUNCHER: none *
    CHPL_TIMERS: generic
    CHPL_UNWIND: none
    CHPL_MEM: jemalloc
    CHPL_ATOMICS: intrinsics
    CHPL_GMP: system
    CHPL_HWLOC: hwloc
    CHPL_REGEXP: re2
    CHPL_LLVM: none
    CHPL_AUX_FILESYS: none
    CHPL_LIB_PIC: none

When I run the tests in test/interop/C/exportString the C tests are skipped. Additionally my $(CC) compiler is clang-9. Is there some module loading/unloading I have to do to match the nightly testing environment, here? (I suspect there is, and will look into it, just a prelude question if you will).

@gbtitus
Copy link
Member

gbtitus commented Jul 24, 2019

@gbtitus, I am unsure of how to replicate the testing environment listed below:

Yes, you'll have to do some module adjustment to replicate this environment. Generally: on the system where the corresponding testing is done, make sure the PrgEnv module you have loaded is PrgEnv-cray. That selects the target compiler. You'll also need to export CHPL_COMM=none explicitly, because the default comm layer on XC systems is ugni. And you'll need to export CHPL_LAUNCHER=none explicitly, because the default launcher on XC systems is whatever (PBS or slurm) is installed on the system.

Copy link
Member

@gbtitus gbtitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo the slight phrasing change I mentioned this looks good, but I'd like to see it tested before merging.

@dlongnecke-cray
Copy link
Contributor Author

Thank you for the help!

@dlongnecke-cray dlongnecke-cray merged commit d16023b into chapel-lang:master Jul 26, 2019
@dlongnecke-cray dlongnecke-cray deleted the sli-suppress-cray-cc branch July 26, 2019 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants