-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local index addition for block distributed sparse domains #13411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@benharsh -- do you mind giving this a look? |
benharsh
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks fine to me. I'd prefer that we have a better default value for locales than nil
, but that's OK for now.
The word "nil" for the default argument value is dropped in docs for some reason, filed an issue: #13531 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #12673 by adding
addOn
argument to thebulkAdd
interface.In order to track the local domain object, this PR also adds
myLocDom
toSparseBlockDom
class similar tomyLocArr
.While implementing this, I noticed the problem with the
nnz
field forSparseBlock
. See #13410. I think that issue must be resolved before this PR is merged. The issue is somewhat subtle and hard to bump into. However, local index addition implemented in this PR will mess upnnz
and probably none of the locales will be able to read the correct size of the domain.TODO:
CHPL_COMM=gasnet
test/users/engin/sparse_bulk*
passes