Fix Chapel-LLVM build with LLVM master #13404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mppf
force-pushed
the
fix-llvm-build-master
branch
from
af216e4 to
a5fc04b
Compare
dmk42
reviewed
Jul 24, 2019
Since PR chapel-lang#7004, we have been rebuilding third-party libraries when relevant Makefiles change. This has also applied to LLVM builds since chapel-lang#12102. However, this presents challenges to developers modifying these Makefiles since the LLVM build can take more than 10 minutes. At the same time, LLVM's cmake-based build system should generally manage dependencies (and for example, do a rebuild if we try to `make install` after upgrading all of the source code files). Therefore, this commit adjusts the 3p-rebuild for LLVM to only remove the install directory and to let LLVM's cmake manage the build directory.
mppf
force-pushed
the
fix-llvm-build-master
branch
from
2c1346c to
e04e42a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Makefiles to support LLVM 9 and 10
Resolves a build-time error. Since the list of libraries we need to work with clang changed, add some Makefile logic to track the LLVM major version number.
Do not force full LLVM rebuild when relevant Makefiles change
Since PR #7004, we have been rebuilding third-party libraries
when relevant Makefiles change. This has also applied to LLVM
builds since #12102.
However, this presents challenges to developers modifying these
Makefiles since the LLVM build can take more than 10 minutes.
At the same time, LLVM's cmake-based build system should generally manage
dependencies (and for example, do a rebuild if we try to
make installafter upgrading all of the source code files).
Therefore, this commit adjusts the 3p-rebuild for LLVM to only
remove the install directory and to let LLVM's cmake manage the
build directory.
Reviewed by @dmk42 - thanks!
Passed full local --llvm testing.