-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User experience improvements #2
Conversation
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
If Chapel is installed with a prefix installation, there is no need to set CHPL_HOME, but |
Yes, this PR searches PATH for any chapel-vscode/src/ChplPaths.ts Line 68 in 7f5ddef
|
Right, but a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me!
Could you please update the readme so that it tracks the new features? Right now it still asks users to set CHPL_HOME
explicitly.
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
This PR improves the user experience of this extension by more gracefully handling errors and introducing ways of recovering from those errors
In this PR
chapel-py
is not built, prompts the user to build it (and builds it for them)[Reviewed by @ShreyasKhandekar]