Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vscode extension #1

Merged
merged 13 commits into from
Jan 18, 2024
Merged

Add vscode extension #1

merged 13 commits into from
Jan 18, 2024

Conversation

jabraham17
Copy link
Member

@jabraham17 jabraham17 commented Jan 10, 2024

This PR replaces everything in this repo with a vscode extension written in TypeScript that contributes a number of features

Features

  • Syntax highlighting for the Chapel language
  • A client for the chplcheck LSP server
    • If a user sets CHPL_HOME in the vscode config and has the python bindings built, can find and run chplcheck in LSP mode
  • A client for the chpl-language-server
    • If a user sets CHPL_HOME in the vscode config and has the python bindings built, can find and run chpl-language-server
  • Chapel code snippets
    • supports several parallel loop patterns, as well as a basic hello world
  • An icon for .chpl files
  • Syntax highlighting for the Chapel AST, dumped by the compiler

[Reviewed by @ShreyasKhandekar]

Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
@ShreyasKhandekar ShreyasKhandekar requested review from ShreyasKhandekar and removed request for tzinsky January 18, 2024 01:21
Copy link
Contributor

@ShreyasKhandekar ShreyasKhandekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic!
Instead of going through the code here I downloaded and installed the extension locally in VS Code and played around with it. Installation was pretty straightforward.
The syntax checking, definition lookup, and snippets all work great and I love it.

I was looking for a way to see what subset of features of the LSP this extension supports, maybe a checklist of sorts? Is there a way for us to see that?

I have some very minor comments below.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
Copy link
Member Author

I was looking for a way to see what subset of features of the LSP this extension supports, maybe a checklist of sorts? Is there a way for us to see that?

I have rewritten the README with this information

Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17 jabraham17 merged commit 38c7931 into chapel-lang:main Jan 18, 2024
@jabraham17 jabraham17 deleted the contribute-extension branch January 18, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants