[build_grimoirelab] Improve support for testing #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to build pacakges before running tests if prebuilt packages are available. This patch allows to use --test alone, without --build, and removes the previous code that run --build for --test always (even if --build was not specified in the command line).
New option, --confdir, for specifying a directory with configuration files for testing, that will be copied to the corresponding repository before tests are run.
…and. run_command can now accept environment variables. This allows it to be called with pip enviroment variables set for using packages in a certain directory (PIP_FIND_LINKS). This patch also implements using this variables for setup.py test, so that packages can be tested more easily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves support for testing GrimoireLab pip packages. Now, it allows to run
setup.py testfor each module, including configuration files for testing (eg, when they are needed to express addresses or credentials to access services). One of the commits also removes the need to build before testing, allowing that way to test already built packages (in fact, they will be used as dependencies, since unit tests will always be run on the source code).Now, all build packages for a GrimoireLab distro can be tested by running (assuming built packages are in
dist, configuration files for testing are intestconf, which will have one subdirectory per module with testing config files, with the same path they should be copied to the source code repo befor running tests, andreleaseis the release file to test) :