Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weird warning #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jgbarah
Copy link
Contributor

@jgbarah jgbarah commented Aug 7, 2018

This is just to fix a weird warning, see chaoss/grimoirelab-sirmordred#192

This fix can be saafely removed once the problem is fixed in the imported modules.

This is just to fix a weird warning, see

chaoss/grimoirelab-sirmordred#192

This fix can be saafely removed once the problem is fixed in the
imported modules.
Copy link
Member

@valeriocos valeriocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valeriocos
Copy link
Member

I would wait until tomorrow afternoon to merge it, in case other reviewers want to have a look at this PR.

@jgbarah
Copy link
Contributor Author

jgbarah commented Aug 7, 2018

Thanks, @valeriocos. I've opened another pr for SirMordred, see above.

Copy link
Member

@acs acs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants