Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation]: Cleanup docker installation docs #2981

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Documentation]: Cleanup docker installation docs #2981

wants to merge 1 commit into from

Conversation

lpanni
Copy link

@lpanni lpanni commented Feb 3, 2025 •
edited
Loading

Description
Docs:

  • Moved apple silicon prerequisites from the Ubuntu to the OSX section
  • Fixed docker-compose file reference for external db usage

Notes for Reviewers
Probably the docker documentation needs to be consolidated entirely.

Signed commits

  • Yes, I signed my commits.

@lpanni lpanni requested a review from sgoggins as a code owner February 3, 2025 10:33
@lpanni lpanni force-pushed the fix/docker branch 2 times, most recently from 35cc05f to f159b18 Compare February 4, 2025 10:44
@lpanni
Docs: clean up docker install docs
54b41b1 
- move apple silicon specifics from ubuntu to OSX section
- fix docker compose commands
- adjust heading level for Docker section

Signed-off-by: Panni, Lukas <[email protected]>
@GregSutcliffe
Copy link
Collaborator

Can't comment on the Sillicon stuff, but 👍 on the rest

@MoralCode
Copy link
Contributor

MoralCode commented Feb 17, 2025 •
edited
Loading

an additional change that could be useful in this PR (since changes are already being made to docker docs):

i did notice that the docker build command on this page has a filepath slightly wrong (FYI im using podman on a debian based system), it should be:
$ docker build -t <tag_name> -f docker/<service name>/Dockerfile . (i.e. removing the util/ from the path to the dockerfiles.

also the three options available for subdirectories are now backend, database, and rabbitmq - frontend no longer exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgoggins sgoggins Awaiting requested review from sgoggins sgoggins is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lpanni @GregSutcliffe @MoralCode