Refactor and add routes for evolution metrics #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'code_changes' metric now accepts a repo_group_id and repo_id instead of a repo_url Signed-off-by: Parth Sharma <[email protected]>
Signed-off-by: Parth Sharma <[email protected]>
Signed-off-by: Parth Sharma <[email protected]>
Signed-off-by: Parth Sharma <[email protected]>
Signed-off-by: Parth Sharma <[email protected]>
Signed-off-by: Parth Sharma <[email protected]>
Signed-off-by: Parth Sharma <[email protected]>
parthsharma2
changed the title
Signed-off-by: Parth Sharma <[email protected]>
Note: TODO add apiSuccessExample Signed-off-by: Parth Sharma <[email protected]>
Signed-off-by: Parth Sharma <[email protected]>
Signed-off-by: Parth Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repo_group_idandrepo_idinstead ofrepo_urlrepo-groups/:repo_group_id/code-changes: This route returns the output for the metric 'code_changes' for a repo group with the givenrepo_group_id.repo-groups/<repo_group_id>/repo/<repo_id>/code-changes: This route returns the output for the metric 'code_changes' about a repo with a givenrepo_idwithin a repo group with the givenrepo_group_id.Suggestion: Adding routes requires writing a lot of repeating code. I suggest we create a utility function for adding routes. Something similar to
addMetricandaddTimeseriesfunctions.Update: Added helper functions for simplifying the creation of API endpoints. They are
addRepoGroupMetricfor creating/repo-groups/:repo_group_id/[metric]endpoints.addRepoMetricfor creating/repo-groups/:repo_group_id/repos/:repo_id/[metric]endpoints.routifyhelpsaddRepoGroupMetric&addRepoMetric. Similar toflaskifyAll of these functions are implemented in the
Serverclass.