Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user subcommand CLI #1912

Merged
merged 5 commits into from
Jul 25, 2022
Merged

Add user subcommand CLI #1912

merged 5 commits into from
Jul 25, 2022

Conversation

Priya730
Copy link
Contributor

@Priya730 Priya730 commented Jul 8, 2022 •
edited
Loading

Signed-off-by: Priya Srivastava [email protected]
This is work in progress
Description

  • Progress till now: Add user subcommand with admin flag (more work (access, permissions) on admin role required)
  • Next steps that I'm working on: password hashing
  • email to login
  • Important: changes need to be made in multicommad.py for command to implement

This PR fixes #

Notes for Reviewers
Made this PR to keep track of the progress
Signed commits

  • Yes, I signed my commits.

@sgoggins sgoggins requested a review from Ulincsys July 8, 2022 10:03
@Priya730
Add user with email
2f21f56 
Add user with unique email and username command

Signed-off-by: Priya Srivastava <[email protected]>
@Priya730
Password hashing added
1e57f9a 
Signed-off-by: Priya Srivastava <[email protected]>
@Priya730
message updated
f0696dc 
Signed-off-by: Priya Srivastava <[email protected]>
@Priya730
Copy link
Contributor Author

Current behaviour:
current

sgoggins
sgoggins previously approved these changes Jul 20, 2022
View reviewed changes
@sgoggins
Copy link
Member

@Priya730 : Is this ready to merge?

@Priya730
Ready to merge
53e88ea 
Added instructions for command usage

Signed-off-by: Priya Srivastava <[email protected]>
@Priya730
Copy link
Contributor Author

Priya730 commented Jul 25, 2022 •
edited
Loading

@sgoggins Please review, branch ready to merge

@Priya730 Priya730 marked this pull request as ready for review July 25, 2022 06:15
@sgoggins sgoggins merged commit b4a9e8f into chaoss:main Jul 25, 2022
@Priya730 Priya730 mentioned this pull request Sep 4, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgoggins sgoggins sgoggins approved these changes

@Ulincsys Ulincsys Awaiting requested review from Ulincsys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Priya730 @sgoggins