Travis: Support newer gcc versions #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fact, run on both gcc 4.9, 5, 6 and 7. This is probably overkill in the long run. If it turns out to be a maintenance nightmare, we can drop one or more of these easily.
perlun
force-pushed
the
feature/support-newer-gcc-versions
branch
from
0c92d41 to
d4e1e65
Compare
perlun
force-pushed
the
feature/support-newer-gcc-versions
branch
2 times, most recently
from
2f2b6e8 to
24139f6
Compare
perlun
force-pushed
the
feature/support-newer-gcc-versions
branch
from
24139f6 to
28ff222
Compare
The comment approach did not work for me; the warning level seemed not to be 3 as it ought to be. Maybe if we explicitly set it to 4, things will work.
perlun
force-pushed
the
feature/support-newer-gcc-versions
branch
from
a7895c6 to
2b7e3fd
Compare
Should be used when compiling the libraries and servers also.
This should work. The commment must be outside of the block, if it exists...
Inspired by ponylang/ponyc#1581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fact, run on both gcc 4.9, 5, 6 and 7. This is probably overkill in the long run. If it turns out to be a maintenance nightmare, we can drop one or more of these easily.
Closes #83. 🎉