Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add darcy penalization in vof #990

Merged
merged 8 commits into from
Jan 24, 2024
Merged

Add darcy penalization in vof #990

merged 8 commits into from
Jan 24, 2024

Conversation

AmishgaAlphonius
Copy link
Collaborator

Description of the problem

  • As an alternative to viscous penalization for solid phase modelling in phase change simulation, a Darcy-like penalization as implemented for single fluid flows. However, laser powder bed fusion (LPBF) simulations are two-fluid simulations.

Description of the solution

  • This Darcy-like penalization is now extended to two-fluid VOF simulations with the PhaseChangeDarcyVOFAssembler assembler class.

How Has This Been Tested?

  • All tests have passed.
  • A new application test has been added: applications_tests/lethe-fluid/vof_phase_change_darcy.prm (.output)

Documentation

  • Documentation related to this feature was updated (doc/source/parameters/cfd/velocity_source.rst)

Comments

  • Other minor changes and corrections were brought to the documentation.

Copy link
Contributor

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very few comments. Very very good PR :)

source/solvers/navier_stokes_vof_assemblers.cc Outdated Show resolved Hide resolved
source/solvers/navier_stokes_vof_assemblers.cc Outdated Show resolved Hide resolved
source/solvers/physical_properties_manager.cc Show resolved Hide resolved
@AmishgaAlphonius AmishgaAlphonius force-pushed the add-darcy-penalization-in-vof branch from f17aa38 to 02af146 Compare January 23, 2024 13:38
Copy link
Collaborator

@oguevremont oguevremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

doc/source/parameters/cfd/velocity_source.rst Show resolved Hide resolved
include/solvers/navier_stokes_vof_assemblers.h Outdated Show resolved Hide resolved
Copy link
Collaborator

@hepap hepap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a lot of comments! Nice, I like the way you handle both fluids in the assembler :)

include/solvers/navier_stokes_vof_assemblers.h Outdated Show resolved Hide resolved
doc/source/parameters/cfd/physical_properties.rst Outdated Show resolved Hide resolved
@blaisb blaisb merged commit 9c9a72b into master Jan 24, 2024
15 checks passed
@blaisb blaisb deleted the add-darcy-penalization-in-vof branch January 24, 2024 15:45
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024
Description of the problem
As an alternative to viscous penalization for solid phase modelling in phase change simulation, a Darcy-like penalization as implemented for single fluid flows. However, laser powder bed fusion (LPBF) simulations are two-fluid simulations.
Description of the solution
This Darcy-like penalization is now extended to two-fluid VOF simulations with the PhaseChangeDarcyVOFAssembler assembler class.
How Has This Been Tested?
All tests have passed.
A new application test has been added: applications_tests/lethe-fluid/vof_phase_change_darcy.prm (.output)
Documentation
Documentation related to this feature was updated (doc/source/parameters/cfd/velocity_source.rst)

Co-authored-by: Bruno Blais <[email protected]>
Co-authored-by: Olivier Guévremont <[email protected]>
Co-authored-by: hepap <[email protected]>
Former-commit-id: 9c9a72b
blaisb added a commit that referenced this pull request Sep 30, 2024
Description of the problem
As an alternative to viscous penalization for solid phase modelling in phase change simulation, a Darcy-like penalization as implemented for single fluid flows. However, laser powder bed fusion (LPBF) simulations are two-fluid simulations.
Description of the solution
This Darcy-like penalization is now extended to two-fluid VOF simulations with the PhaseChangeDarcyVOFAssembler assembler class.
How Has This Been Tested?
All tests have passed.
A new application test has been added: applications_tests/lethe-fluid/vof_phase_change_darcy.prm (.output)
Documentation
Documentation related to this feature was updated (doc/source/parameters/cfd/velocity_source.rst)

Co-authored-by: Bruno Blais <[email protected]>
Co-authored-by: Olivier Guévremont <[email protected]>
Co-authored-by: hepap <[email protected]>
Former-commit-id: 9c9a72b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants