-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add darcy penalization in vof #990
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very few comments. Very very good PR :)
f17aa38
to
02af146
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Co-authored-by: Olivier Guévremont <[email protected]>
fe797b1
to
da0f158
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a lot of comments! Nice, I like the way you handle both fluids in the assembler :)
Co-authored-by: hepap <[email protected]>
Description of the problem As an alternative to viscous penalization for solid phase modelling in phase change simulation, a Darcy-like penalization as implemented for single fluid flows. However, laser powder bed fusion (LPBF) simulations are two-fluid simulations. Description of the solution This Darcy-like penalization is now extended to two-fluid VOF simulations with the PhaseChangeDarcyVOFAssembler assembler class. How Has This Been Tested? All tests have passed. A new application test has been added: applications_tests/lethe-fluid/vof_phase_change_darcy.prm (.output) Documentation Documentation related to this feature was updated (doc/source/parameters/cfd/velocity_source.rst) Co-authored-by: Bruno Blais <[email protected]> Co-authored-by: Olivier Guévremont <[email protected]> Co-authored-by: hepap <[email protected]> Former-commit-id: 9c9a72b
Description of the problem As an alternative to viscous penalization for solid phase modelling in phase change simulation, a Darcy-like penalization as implemented for single fluid flows. However, laser powder bed fusion (LPBF) simulations are two-fluid simulations. Description of the solution This Darcy-like penalization is now extended to two-fluid VOF simulations with the PhaseChangeDarcyVOFAssembler assembler class. How Has This Been Tested? All tests have passed. A new application test has been added: applications_tests/lethe-fluid/vof_phase_change_darcy.prm (.output) Documentation Documentation related to this feature was updated (doc/source/parameters/cfd/velocity_source.rst) Co-authored-by: Bruno Blais <[email protected]> Co-authored-by: Olivier Guévremont <[email protected]> Co-authored-by: hepap <[email protected]> Former-commit-id: 9c9a72b
Description of the problem
Description of the solution
PhaseChangeDarcyVOFAssembler
assembler class.How Has This Been Tested?
applications_tests/lethe-fluid/vof_phase_change_darcy.prm
(.output
)Documentation
doc/source/parameters/cfd/velocity_source.rst
)Comments