Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkpointing the insertion object. #964

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Checkpointing the insertion object. #964

merged 5 commits into from
Dec 13, 2023

Conversation

OGaboriault
Copy link
Collaborator

Description of the problem

  • The number of inserted particle wasn't being check-pointed. The "number of particle" parameter had to be adjusted in the prm file when restarting a simulation which is annoying especially if particle cross an output boundary condition before the restart and there's still particle left to insert in the simulation.

Description of the solution

  • The attributes "particles_of_each_type_remaining" and "current_inserting_particle_type" are being check-pointed with a virtual void function.

How Has This Been Tested?

  • Current tests have been updated in a way that the total number of particle at the end of the test says the same. In brief, the parameter "number of particle" describe the number of particle at the end of the test, which wasn't the case previously.

Documentation

  • N/A

Comments

  • The circle_restart test output file had to be updated... it's hard to explain, but I think that the insertion method algorithm change after that the creation of the old restart file. This means that we are not able the generated the exact old initial condition of the test. I had to generated the ".insertion_object" restart file, thus running the simulation from t=0 to the checkpoint time step, but since the initial condition is not the same, the restart files and the output file are not the same.

@OGaboriault OGaboriault self-assigned this Dec 11, 2023
@OGaboriault
Copy link
Collaborator Author

I think I'll need to run the CFD-DEM examples since they are using the restart functionality...

blaisb
blaisb reviewed Dec 11, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
blaisb
blaisb reviewed Dec 11, 2023
View reviewed changes
include/dem/insertion.h Outdated Show resolved Hide resolved
blaisb
blaisb requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments and doc changes to address

blaisb
blaisb approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment and this is ready for merge

source/dem/dem.cc Outdated Show resolved Hide resolved
@blaisb blaisb merged commit 7c362e3 into master Dec 13, 2023
15 checks passed
@blaisb blaisb deleted the dem_restart_insertion branch December 13, 2023 13:26
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024
@OGaboriault @blaisb
Checkpointing the insertion object. (chaos-polymtl#964)
7edb612 
Description of the problem
The number of inserted particle wasn't being check-pointed. The "number of particle" parameter had to be adjusted in the prm file when restarting a simulation which is annoying especially if particle cross an output boundary condition before the restart and there's still particle left to insert in the simulation.

Description of the solution
The attributes "particles_of_each_type_remaining" and "current_inserting_particle_type" are being check-pointed with a virtual void function.

How Has This Been Tested?
Current tests have been updated in a way that the total number of particle at the end of the test says the same. In brief, the parameter "number of particle" describe the number of particle at the end of the test, which wasn't the case previously.

Documentation
N/A

Comments
The circle_restart test output file had to be updated... it's hard to explain, but I think that the insertion method algorithm change after that the creation of the old restart file. This means that we are not able the generated the exact old initial condition of the test. I had to generated the ".insertion_object" restart file, thus running the simulation from t=0 to the checkpoint time step, but since the initial condition is not the same, the restart files and the output file are not the same.

Co-authored-by: Bruno Blais <[email protected]>
Former-commit-id: 7c362e3
blaisb added a commit that referenced this pull request Sep 30, 2024
@OGaboriault @blaisb
Checkpointing the insertion object. (#964)
2b847ee 
Description of the problem
The number of inserted particle wasn't being check-pointed. The "number of particle" parameter had to be adjusted in the prm file when restarting a simulation which is annoying especially if particle cross an output boundary condition before the restart and there's still particle left to insert in the simulation.

Description of the solution
The attributes "particles_of_each_type_remaining" and "current_inserting_particle_type" are being check-pointed with a virtual void function.

How Has This Been Tested?
Current tests have been updated in a way that the total number of particle at the end of the test says the same. In brief, the parameter "number of particle" describe the number of particle at the end of the test, which wasn't the case previously.

Documentation
N/A

Comments
The circle_restart test output file had to be updated... it's hard to explain, but I think that the insertion method algorithm change after that the creation of the old restart file. This means that we are not able the generated the exact old initial condition of the test. I had to generated the ".insertion_object" restart file, thus running the simulation from t=0 to the checkpoint time step, but since the initial condition is not the same, the restart files and the output file are not the same.

Co-authored-by: Bruno Blais <[email protected]>
Former-commit-id: 7c362e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blaisb blaisb blaisb approved these changes

Assignees

@OGaboriault OGaboriault

Labels
Enhancement New feature or request Reviewed and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OGaboriault @blaisb