Bugfix, dem fixing critical rayleigh time step #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaisb
approved these changes
Nov 27, 2023
|
Ehmm.... a multicore test is failling on dealii:master but not on dealii:v9.5.0 |
11 tasks
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description of the problem The inspection of the DEM time step was wrong. It should be searching for the more restrictive rayleigh time, that is the minimum rayleigh time, not the maximum. Description of the solution The rayleigh time step is initialize to infinity. We use std::min instead of std::max. How Has This Been Tested? One test has been updated. All the other test are still succeeding Documentation N/A Former-commit-id: b43c561
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
…ymtl#1203) Description The critical Rayleigh time step was not properly implemented in CFD-DEM, even tho it was fixed in the past for DEM (see chaos-polymtl#776 and chaos-polymtl#939) Solution Changed to the same calculation as done in DEM. Testing Unresolved CFD-DEM application tests were modified according to the new ratio. Former-commit-id: 21b7d0f
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description of the problem The inspection of the DEM time step was wrong. It should be searching for the more restrictive rayleigh time, that is the minimum rayleigh time, not the maximum. Description of the solution The rayleigh time step is initialize to infinity. We use std::min instead of std::max. How Has This Been Tested? One test has been updated. All the other test are still succeeding Documentation N/A Former-commit-id: b43c561
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description The critical Rayleigh time step was not properly implemented in CFD-DEM, even tho it was fixed in the past for DEM (see #776 and #939) Solution Changed to the same calculation as done in DEM. Testing Unresolved CFD-DEM application tests were modified according to the new ratio. Former-commit-id: 21b7d0f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
Description of the solution
How Has This Been Tested?
Documentation