Making the uniform insertion method deprecated #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaisb
requested changes
Nov 13, 2023
blaisb
requested changes
Nov 13, 2023
blaisb
approved these changes
Nov 13, 2023
blaisb
added
Reviewed and ready to merge
and removed
Reviewed and waiting for changes
labels
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description of the problem The uniform and non-uniform insertion method were redundant. The uniform insertion is limited in it's simulation applications by the fact that the particles are perfectly stack on top of each other. Description of the solution The uniform method has been deprecated. The non-uniform method has been renamed to volume method. How Has This Been Tested? All application tests passed. Some test output had to be re-generated. Documentation DEM / Insertion_Info Future changes Add the insertion distribution object in the insertions classes. Add the log-normal diameter distribution. Former-commit-id: f31dca7
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description of the problem The uniform and non-uniform insertion method were redundant. The uniform insertion is limited in it's simulation applications by the fact that the particles are perfectly stack on top of each other. Description of the solution The uniform method has been deprecated. The non-uniform method has been renamed to volume method. How Has This Been Tested? All application tests passed. Some test output had to be re-generated. Documentation DEM / Insertion_Info Future changes Add the insertion distribution object in the insertions classes. Add the log-normal diameter distribution. Former-commit-id: f31dca7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
Description of the solution
How Has This Been Tested?
Documentation
Future changes