-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Lethe applications #882
Changes from all commits
ec9777c
24bc30d
4871767
7f55d63
0a6e78d
692c4a9
f1cf952
ca98a06
32c63d4
d5e38b9
e3d206c
7bd3ebe
f1c8da2
a672848
dccc6da
7816ef1
da06c9f
e9c48e7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
# Change Log | ||
All notable changes to the Lethe project will be documented in this file. | ||
|
||
The format is based on [Keep a Changelog](http://keepachangelog.com/). | ||
|
||
## [Master] - 2023-09-19 | ||
|
||
### Changed | ||
|
||
- MAJOR All the applications were renamed [#882](https://github.com/lethe-cfd/lethe/pull/882): `gls_navier_stokes` is now `lethe-fluid`, `gd_navier_stokes` is now `lethe-fluid-block`, `nitsche_navier_stokes` is now `lethe-fluid-nitsche`, `gls_sharp_navier_stokes` is now `lethe-fluid-sharp`, `gls_vans` is now `lethe-fluid-vans`, `mf_navier_stokes` is now `lethe-fluid-matrix-free`, `dem` is now `lethe-particles`, `cfd_dem_coupling` is now `lethe-fluid-particles`, `rpt3d` is now `lethe-rpt-3d`, `rpt_cell_reconstruction_3d` is now `lethe-rpt-cell-reconstruction-3d`, `rpt_fem_reconstruction_3d` is now `lethe-rpt-fem-reconstruction-3d`, and `rpt_l2_projection_3d` is now `lethe-rpt-l2-projection-3d`. | ||
|
||
## [Sample] - YYYY/MM/DD | ||
|
||
### Added | ||
|
||
- MAJOR/MINOR/PATCH Description (#PR). | ||
|
||
### Changed | ||
|
||
- MAJOR/MINOR/PATCH Description (#PR). | ||
|
||
### Deprecated | ||
|
||
- MAJOR/MINOR/PATCH Description (#PR). | ||
|
||
### Removed | ||
|
||
- MAJOR/MINOR/PATCH Description (#PR). | ||
|
||
### Fixed | ||
|
||
- MAJOR/MINOR/PATCH Description (#PR). |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,19 @@ | ||
foreach(_target IN ITEMS | ||
cfd_dem_coupling | ||
dem | ||
lethe-fluid-particles | ||
lethe-particles | ||
dem_parameter_template | ||
gd_navier_stokes | ||
gls_navier_stokes | ||
nitsche_navier_stokes | ||
gls_sharp_navier_stokes | ||
gls_vans | ||
mf_navier_stokes | ||
lethe-fluid-block | ||
lethe-fluid | ||
lethe-fluid-nitsche | ||
lethe-fluid-sharp | ||
lethe-fluid-vans | ||
lethe-fluid-matrix-free | ||
initial_conditions | ||
navier_stokes_parameter_template | ||
rpt_3d | ||
rpt_cell_reconstruction_3d | ||
rpt_fem_reconstruction_3d | ||
rpt_l2_projection_3d) | ||
lethe-rpt-3d | ||
lethe-rpt-cell-reconstruction-3d | ||
lethe-rpt-fem-reconstruction-3d | ||
lethe-rpt-l2-projection-3d) | ||
add_subdirectory(${_target}) | ||
install(TARGETS ${_target}) | ||
endforeach() |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
add_executable(lethe-fluid-block gd_navier_stokes.cc) | ||
deal_ii_setup_target(lethe-fluid-block) | ||
target_link_libraries(lethe-fluid-block lethe-solvers) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
add_executable(lethe-fluid-matrix-free mf_navier_stokes.cc) | ||
deal_ii_setup_target(lethe-fluid-matrix-free) | ||
target_link_libraries(lethe-fluid-matrix-free lethe-solvers) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
add_executable(lethe-fluid-nitsche nitsche_navier_stokes.cc) | ||
deal_ii_setup_target(lethe-fluid-nitsche) | ||
target_link_libraries(lethe-fluid-nitsche lethe-solvers) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
add_executable(lethe-fluid-particles cfd_dem_coupling.cc) | ||
deal_ii_setup_target(lethe-fluid-particles) | ||
target_link_libraries(lethe-fluid-particles lethe-fem-dem) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
add_executable(lethe-fluid-sharp gls_sharp_navier_stokes.cc) | ||
deal_ii_setup_target(lethe-fluid-sharp) | ||
target_link_libraries(lethe-fluid-sharp lethe-fem-dem) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
add_executable(lethe-fluid-vans gls_vans.cc) | ||
deal_ii_setup_target(lethe-fluid-vans) | ||
target_link_libraries(lethe-fluid-vans lethe-fem-dem) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
add_executable(lethe-fluid gls_navier_stokes.cc) | ||
deal_ii_setup_target(lethe-fluid) | ||
target_link_libraries(lethe-fluid lethe-solvers) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
add_executable(lethe-particles dem.cc) | ||
deal_ii_setup_target(lethe-particles) | ||
target_link_libraries(lethe-particles lethe-core lethe-dem) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
add_executable(lethe-rpt-3d rpt_3d.cc) | ||
deal_ii_setup_target(lethe-rpt-3d) | ||
target_link_libraries(lethe-rpt-3d lethe-rpt) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
add_executable(lethe-rpt-cell-reconstruction-3d rpt_cell_reconstruction_3d.cc) | ||
deal_ii_setup_target(lethe-rpt-cell-reconstruction-3d) | ||
target_link_libraries(lethe-rpt-cell-reconstruction-3d lethe-rpt) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
add_executable(lethe-rpt-fem-reconstruction-3d rpt_fem_reconstruction_3d.cc) | ||
deal_ii_setup_target(lethe-rpt-fem-reconstruction-3d) | ||
target_link_libraries(lethe-rpt-fem-reconstruction-3d lethe-rpt) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
add_executable(lethe-rpt-l2-projection-3d rpt_l2_projection_3d.cc) | ||
deal_ii_setup_target(lethe-rpt-l2-projection-3d) | ||
target_link_libraries(lethe-rpt-l2-projection-3d lethe-rpt) |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
add_subdirectory(cfd_dem_coupling) | ||
add_subdirectory(dem) | ||
add_subdirectory(gd_navier_stokes) | ||
add_subdirectory(gls_navier_stokes) | ||
add_subdirectory(gls_sharp_navier_stokes) | ||
add_subdirectory(gls_vans) | ||
add_subdirectory(lethe-fluid-particles) | ||
add_subdirectory(lethe-particles) | ||
add_subdirectory(lethe-fluid-block) | ||
add_subdirectory(lethe-fluid) | ||
add_subdirectory(lethe-fluid-sharp) | ||
add_subdirectory(lethe-fluid-vans) | ||
add_subdirectory(initial_conditions) | ||
add_subdirectory(mf_navier_stokes) | ||
add_subdirectory(nitsche_navier_stokes) | ||
add_subdirectory(rpt_cell_reconstruction_3d) | ||
add_subdirectory(rpt_fem_reconstruction_3d) | ||
add_subdirectory(rpt_l2_projection_3d) | ||
add_subdirectory(lethe-fluid-matrix-free) | ||
add_subdirectory(lethe-fluid-nitsche) | ||
add_subdirectory(lethe-rpt-cell-reconstruction-3d) | ||
add_subdirectory(lethe-rpt-fem-reconstruction-3d) | ||
add_subdirectory(lethe-rpt-l2-projection-3d) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, ''particles'' should be renamed to ''dem'' as this is what people will look for as a key work. I understand the concept of wanting to use words instead of acronyms. However, the current naming scheme is also not consistent in that regard with the use of ''vans'' and ''rpt''. I do not have a strong opinion on the use of ''fluid'' over ''cfd'' as ''fluid model'' or other keywords including ''fluid'' are very common.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blaisb what is your opinion on this?