Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CFD-DEM tests that have restarts to start with "restart_" #1400

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

blaisb
Copy link
Contributor

@blaisb blaisb commented Jan 2, 2025

Description

While refactoring the DEM, @OGaboriault and I realized that the tests that have restart components are weirdly named. Some start with restart_, some end with _restart, and so on and so forth. This is a first step to uniformize the name of the tests that include restarts for CFD-DEM

Testing

Only the test names have been changed, nothing has changed regarding the results or the restart files themselves.

Documentation

Nothing changed here.

Miscellaneous (will be removed when merged)

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Copyright headers are present and up to date
  • Lethe documentation is up to date
  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent
  • If parameters are modified, the tests and the documentation of examples are up to date
  • Changelog (CHANGELOG.md) is up to date if the refactor affects the user experience or the codebase

Pull request related list:

  • No other PR is open related to this refactoring
  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If any future works is planned, an issue is opened
  • The PR description is cleaned and ready for merge

@blaisb blaisb added Quick fix Ready for review Refactoring This PR is only refactoring or clean up labels Jan 2, 2025
@blaisb blaisb requested a review from OGaboriault January 2, 2025 00:23
@blaisb blaisb merged commit 885cdbc into master Jan 2, 2025
11 checks passed
@blaisb blaisb deleted the change_cfd_dem_restart_test_names branch January 2, 2025 14:25
OresteMarquis pushed a commit that referenced this pull request Jan 8, 2025
Description
While refactoring the DEM, @OGaboriault and I realized that the tests that have restart components are weirdly named. Some start with restart_, some end with _restart, and so on and so forth. This is a first step to uniformize the name of the tests that include restarts for CFD-DEM

Testing
Only the test names have been changed, nothing has changed regarding the results or the restart files themselves.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quick fix Ready for review Refactoring This PR is only refactoring or clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants