-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dem rotating drum example post processing #1394
Dem rotating drum example post processing #1394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments
# Path where the parameter file and the output folder is | ||
path = "." | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use the argparser module instead to specify the path instead of hardcoding it? You can look at the TGV example for how it is used.
for i in range(len(vel_value_x)): | ||
if vel_value_x[i] > 0.: | ||
print(y_graph[i]) | ||
break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this print for?
set friction coefficient wall = 0.85 | ||
set rolling friction wall = 0.025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a very weird set of parameters. Very high friction and low rolling friction? Are you sure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OGaboriault Could you please just add a CHANGELOG entry? |
|
||
parser = argparse.ArgumentParser(description='Arguments for calculation of the velocity profile in the rotating drum') | ||
parser.add_argument("-f", "--folder", type=str, help="Folder path", required=True) | ||
parser.add_argument("-i", "--input", type=str, help="Name of the input file", required=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the input file here? is it the prm file?
If it's the prm file, it woud be better to use --prm for the prm file instead it would be more explicit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is is not the prm, it is the csv file (experimental data).
I can add an other flag for the prm.
The prm is loaded explicitly at line 31.
Description
Added the post processing for the rotating drum example.
Miscellaneous (will be removed when merged)
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: