Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dem rotating drum example post processing #1394

Merged
merged 7 commits into from
Dec 16, 2024

Conversation

OGaboriault
Copy link
Collaborator

Description

Added the post processing for the rotating drum example.

Miscellaneous (will be removed when merged)

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • Lethe documentation is up to date
  • Copyright headers are present and up to date
  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent
  • Links are added to parent .rst files
  • The example is following the standard format

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If any future works is planned, an issue is opened
  • The PR description is cleaned and ready for merge

Copy link
Contributor

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments

Comment on lines 12 to 14
# Path where the parameter file and the output folder is
path = "."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the argparser module instead to specify the path instead of hardcoding it? You can look at the TGV example for how it is used.

Comment on lines 101 to 104
for i in range(len(vel_value_x)):
if vel_value_x[i] > 0.:
print(y_graph[i])
break
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this print for?

Comment on lines +63 to +64
set friction coefficient wall = 0.85
set rolling friction wall = 0.025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very weird set of parameters. Very high friction and low rolling friction? Are you sure?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These parameters give this results, that I'm sure:

image

@blaisb
Copy link
Contributor

blaisb commented Dec 13, 2024

@OGaboriault Could you please just add a CHANGELOG entry?


parser = argparse.ArgumentParser(description='Arguments for calculation of the velocity profile in the rotating drum')
parser.add_argument("-f", "--folder", type=str, help="Folder path", required=True)
parser.add_argument("-i", "--input", type=str, help="Name of the input file", required=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the input file here? is it the prm file?
If it's the prm file, it woud be better to use --prm for the prm file instead it would be more explicit

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is is not the prm, it is the csv file (experimental data).

I can add an other flag for the prm.

The prm is loaded explicitly at line 31.

@OGaboriault OGaboriault changed the title Dem rectangular hopper example post processing Dem rotating drum example post processing Dec 16, 2024
@blaisb blaisb merged commit 1e4794a into master Dec 16, 2024
11 checks passed
@blaisb blaisb deleted the dem_rectangular_hopper_example_post_processing branch December 16, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants