Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples update for ball-packing and rectangular-hopper #1374

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

OresteMarquis
Copy link
Collaborator

Description

Update of the .prm and .rst files of the ball-packing and rectangular-hopper examples for the Lethe 1.0 release. The rectangular hopper gave similar curves visually, but the mass flow rate is different than the one stated in the documentation (85.17 vs 84.94 & 90.12 vs 85.09 g/s). Nonetheless, I feel that those results are close enough that it is not necessary to change the example documentation for it.

Miscellaneous (will be removed when merged)

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • Lethe documentation is up to date
  • Copyright headers are present and up to date
  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent
  • Links are added to parent .rst files
  • The example is following the standard format

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If any future works is planned, an issue is opened
  • The PR description is cleaned and ready for merge

@OresteMarquis OresteMarquis added Ready for review Rebased Example Next release PR that would need to be merged before the next release labels Nov 20, 2024
@blaisb blaisb merged commit 54c3c49 into master Nov 20, 2024
4 checks passed
@blaisb blaisb deleted the packing_hopper_examples branch November 20, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Example Next release PR that would need to be merged before the next release Ready for review Rebased
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants