Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples update for gas-solid fluidized and spouted-bed #1370

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

OresteMarquis
Copy link
Collaborator

Description

Update of the .prm and .rst files of the gas-solid fluidized and spouted-bed examples for the Lethe 1.0 release.

Miscellaneous (will be removed when merged)

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • Lethe documentation is up to date
  • Copyright headers are present and up to date
  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent
  • Links are added to parent .rst files
  • The example is following the standard format

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If any future works is planned, an issue is opened
  • The PR description is cleaned and ready for merge

@OresteMarquis OresteMarquis added Documentation Ready for review Example Next release PR that would need to be merged before the next release labels Nov 18, 2024
@OresteMarquis OresteMarquis requested a review from blaisb November 18, 2024 22:06
Copy link
Contributor

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments there and there. A generic piece of advice @OresteMarquis is to put as little parameters as possible in the prm file. If the parameter is not modified, then don't put it in the paramter file, the default value will be fine :)

@OresteMarquis
Copy link
Collaborator Author

How can I know what is the default, so I know what can be removed? I haven't used Lethe enough to know them.

@blaisb
Copy link
Contributor

blaisb commented Nov 19, 2024

How can I know what is the default, so I know what can be removed? I haven't used Lethe enough to know them.

The default values are in the prm template that can be generated with the template parameter executable. I'll show you later if you want.

@blaisb blaisb merged commit 252cd54 into master Nov 20, 2024
4 checks passed
@blaisb blaisb deleted the examples_gas_solid branch November 20, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Example Next release PR that would need to be merged before the next release Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants