-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples update for gas-solid fluidized and spouted-bed #1370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments there and there. A generic piece of advice @OresteMarquis is to put as little parameters as possible in the prm file. If the parameter is not modified, then don't put it in the paramter file, the default value will be fine :)
doc/source/examples/unresolved-cfd-dem/gas-solid-spouted-bed/gas-solid-spouted-bed.rst
Outdated
Show resolved
Hide resolved
doc/source/examples/unresolved-cfd-dem/gas-solid-spouted-bed/gas-solid-spouted-bed.rst
Outdated
Show resolved
Hide resolved
doc/source/examples/unresolved-cfd-dem/gas-solid-spouted-bed/gas-solid-spouted-bed.rst
Outdated
Show resolved
Hide resolved
doc/source/examples/unresolved-cfd-dem/gas-solid-spouted-bed/gas-solid-spouted-bed.rst
Outdated
Show resolved
Hide resolved
doc/source/examples/unresolved-cfd-dem/gas-solid-spouted-bed/gas-solid-spouted-bed.rst
Outdated
Show resolved
Hide resolved
examples/unresolved-cfd-dem/gas-solid-fluidized-bed/gas-solid-fluidized-bed.prm
Outdated
Show resolved
Hide resolved
examples/unresolved-cfd-dem/gas-solid-fluidized-bed/gas-solid-fluidized-bed.prm
Outdated
Show resolved
Hide resolved
examples/unresolved-cfd-dem/gas-solid-spouted-bed/gas-solid-spouted-bed.prm
Outdated
Show resolved
Hide resolved
examples/unresolved-cfd-dem/gas-solid-spouted-bed/gas-solid-spouted-bed.prm
Outdated
Show resolved
Hide resolved
How can I know what is the default, so I know what can be removed? I haven't used Lethe enough to know them. |
The default values are in the prm template that can be generated with the template parameter executable. I'll show you later if you want. |
Description
Update of the .prm and .rst files of the gas-solid fluidized and spouted-bed examples for the Lethe 1.0 release.
Miscellaneous (will be removed when merged)
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: