Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dem examples #1368

Merged
merged 7 commits into from
Nov 19, 2024
Merged

Dem examples #1368

merged 7 commits into from
Nov 19, 2024

Conversation

OGaboriault
Copy link
Collaborator

Description

Review of the bunny drill and granuheap examples.

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • Lethe documentation is up to date
  • Copyright headers are present and up to date
  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent
  • Links are added to parent .rst files
  • The example is following the standard format

Pull request related list:

  • Labels are applied
  • [] There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If any future works is planned, an issue is opened
  • The PR description is cleaned and ready for merge

Copy link
Contributor

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, very few comments, thx for the work done

doc/source/examples/dem/bunny-drill/bunny-drill.rst Outdated Show resolved Hide resolved
doc/source/examples/dem/granuheap/granuheap.rst Outdated Show resolved Hide resolved
@blaisb blaisb merged commit 396f36f into master Nov 19, 2024
4 checks passed
@blaisb blaisb deleted the dem_examples branch November 19, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants