Fix specific heat model with bdf2 #1367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The specific heat model in BDF2 was not protected against a division by zero (dH/dT)
Solution
A tolerance is now added to the denominator (dH/(dT+tol)) to avoid this problem
Testing
No change in the tests
Documentation
No change in the documentation
Miscellaneous (will be removed when merged)
I didn't add a new test because I think the current state of the cp model will probably change to be more robust in BDF2
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: