Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specific heat model with bdf2 #1367

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Fix specific heat model with bdf2 #1367

merged 5 commits into from
Nov 18, 2024

Conversation

hepap
Copy link
Collaborator

@hepap hepap commented Nov 18, 2024

Description

The specific heat model in BDF2 was not protected against a division by zero (dH/dT)

Solution

A tolerance is now added to the denominator (dH/(dT+tol)) to avoid this problem

Testing

No change in the tests

Documentation

No change in the documentation

Miscellaneous (will be removed when merged)

I didn't add a new test because I think the current state of the cp model will probably change to be more robust in BDF2

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Copyright headers are present and up to date
  • Lethe documentation is up to date
  • Fix has unit test(s) (preferred) or application test(s), and restart files are in the generator folder
  • The branch is rebased onto master
  • Changelog (CHANGELOG.md) is up to date
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If the fix is temporary, an issue is opened
  • The PR description is cleaned and ready for merge

@hepap hepap force-pushed the fix_cp_tol_with_bdf2 branch from ddee612 to ecd7b86 Compare November 18, 2024 19:07
@hepap hepap requested review from blaisb and AmishgaAlphonius and removed request for blaisb November 18, 2024 19:23
Copy link
Collaborator

@AmishgaAlphonius AmishgaAlphonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! :)

@blaisb blaisb merged commit ccc21e1 into master Nov 18, 2024
11 checks passed
@blaisb blaisb deleted the fix_cp_tol_with_bdf2 branch November 18, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants