Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dem particle weight #1347

Merged
merged 7 commits into from
Nov 22, 2024
Merged

Dem particle weight #1347

merged 7 commits into from
Nov 22, 2024

Conversation

OGaboriault
Copy link
Collaborator

Description

Default value for the particle weight was outdated. This PR is changing this default value from 10 000 to 1000.
Some test output had to be changed because of this.

Miscellaneous (will be removed when merged)

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Copyright headers are present and up to date
  • Lethe documentation is up to date
  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If any future works is planed, an issue is opened
  • The PR description is cleaned and ready for merge

Copy link
Contributor

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2k seems like a legit default value. Let's use that.

CHANGELOG.md Outdated Show resolved Hide resolved
doc/source/parameters/dem/model_parameters.rst Outdated Show resolved Hide resolved
source/core/parameters_lagrangian.cc Outdated Show resolved Hide resolved
@blaisb
Copy link
Contributor

blaisb commented Nov 20, 2024

@OGaboriault can you rebase the changelog then I can merge?

@OGaboriault
Copy link
Collaborator Author

Done

@blaisb blaisb merged commit 46d2410 into master Nov 22, 2024
11 checks passed
@blaisb blaisb deleted the dem_particle_weight branch November 22, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants