Force chains, add the arbitrary rule

[OGaboriault]

Description

Force chains between local-ghost particle were being duplicated since the arbitrary rule with particle ids was not implemented.

Solution

The execute_contact_calculation function in the force_chain_visualization.h file is templated with the contact type. Weh nwe are dealing with ghost_particle_particle contacts, we apply the rule.

Testing

I could add a test, but I'm not sure what is the best way to do it. It would require two particles, being in two different subdomains.

Documentation

N/A

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

• All in-code documentation related to this PR is up to date (Doxygen format)
• Copyright headers are present and up to date
• Lethe documentation is up to date
• Fix has unit test(s) (preferred) or application test(s), and restart files are in the generator folder
• The branch is rebased onto master
• Changelog (CHANGELOG.md) is up to date
• Code is indented with indent-all and .prm files (examples and tests) with prm-indent

Pull request related list:

• Labels are applied
• There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
• If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
• If the fix is temporary, an issue is opened
• The PR description is cleaned and ready for merge

[blaisb]

I think you need to give those a defaul value otherwise if you have a processor with nothing won't you get an error ? LIke if the vectors are empty

[blaisb]

Wait why is this a Vector of float? This will be in single precision... why do that?

[blaisb]

Smalls changes nothing big

[blaisb]

Suggested change

	// Clear the containers for the next writing time step.
	vertices.clear();
	normal_forces_vector.clear();

You don't need to clear the containers because they will automatically be cleared out by going out of scope since the variables are local to the scope.

[blaisb]

Last changes and ready for merge.

[blaisb]

This could be const

[OGaboriault]

No it cannot. It has something to do with the particle_particle_contact_force.h file.

There's an other function called execute_contact_calculation with the same input parameters. In that function, we clear the tangential overlap, thus it is not const.

I'm not sure if the ParticlesForceChains class needs to inherit from ParticleParticleContactForce, but this is why it cannot be const.

[blaisb]

Perfect