Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cfd dem restart files #1338

Merged
merged 5 commits into from
Nov 2, 2024
Merged

Cfd dem restart files #1338

merged 5 commits into from
Nov 2, 2024

Conversation

OGaboriault
Copy link
Collaborator

@OGaboriault OGaboriault commented Nov 2, 2024

Description

Since the implementation of the double restarts in the dem solver, checkpoint files generated from the dem solver were not longer compatible from the get-go with the CFD-DEM solvers (lethe-fluid-vans and lethe-fluid-particles) since the prefix changed.

Solution

The CFD-DEM solvers now read the ".checkpoint_controller" file to check which version of checkpoint files should be read.

Testing

Every CFD-DEM application tests were updated with the new file names. ( I made sure to rename the file in my IDE so that git keeps track of the change, aka no deleted and new files)

Documentation

N/A

Miscellaneous (will be removed when merged)

Double restarts shouldn't affect this change.

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Copyright headers are present and up to date
  • Lethe documentation is up to date
  • Fix has unit test(s) (preferred) or application test(s), and restart files are in the generator folder
  • The branch is rebased onto master
  • Changelog (CHANGELOG.md) is up to date
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If the fix is temporary, an issue is opened
  • The PR description is cleaned and ready for merge

@blaisb blaisb merged commit 8731788 into master Nov 2, 2024
11 checks passed
@blaisb blaisb deleted the cfd-dem_restart_files branch November 2, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants