Refactor vof curvature l2 projection #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmishgaAlphonius
force-pushed
the
refactor-vof-curvature-l2-projection
branch
from
3ad07fe to
194618c
Compare
AmishgaAlphonius
added
Ready for review
Refactoring
blaisb
requested changes
Nov 4, 2024
| @@ -11,15 +11,19 @@ | |||
|
|
|||
| using namespace dealii; | |||
|
|
|||
|
|
|||
| /** | |||
| * @brief IDs associated to the different subequations solved in Lethe. | |||
| */ | |||
| enum VOFSubequationsID : unsigned int | |||
There was a problem hiding this comment.
can you make this an enum class or it needs to be an enum?
There was a problem hiding this comment.
No there is no particular reason to leave it as an enum, I've switched it to an enum class :)
Comment on lines
199
to
+201
| subequation_string = "VOF phase fraction gradient L2 projection"; | ||
| else if (subequation_id == VOFSubequationsID::curvature_projection) | ||
| subequation_string = "VOF curvature L2 projection"; |
There was a problem hiding this comment.
what is the subequation string used for?
There was a problem hiding this comment.
To print on the terminal, when it is verbose. It is used in the setup_dofs() and solve_linear_system_and_update_solution() methods in VOFLinearSubequationsSolver
AmishgaAlphonius
force-pushed
the
refactor-vof-curvature-l2-projection
branch
from
e389fda to
13ef98a
Compare
hepap
approved these changes
Nov 4, 2024
blaisb
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following PR #1318, this one refactors the curvature projection to be assembled and solved through the VOF subequations interface. Assembly of the matrix and right-hand side for both VOFSubequations (phase fraction gradient and curvature projection) are now done in the same loop without the WorkStream method, as they are pretty simple to assemble.
Testing
The unit test dedicated to the interface has been updated.
Visual inspection of data was done with the rising bubble case using paraview.
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: