Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default coarse grid solver for the geometric multigrid #1322

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

lpsaavedra
Copy link
Collaborator

@lpsaavedra lpsaavedra commented Oct 16, 2024

Description

This PR makes the direct solver the default coarse grid solver for the geometric multigrid alternatives in the matrix-free application.

Testing

All the existent tests pass with this coarse-grid solver. The parameter files were cleaned and the coarse grid solver section removed.

Documentation

The default value was updated in the linear solver section of the documentation.

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Copyright headers are present and up to date
  • Lethe documentation is up to date
  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent
  • If parameters are modified, the tests and the documentation of examples are up to date
  • Changelog (CHANGELOG.md) is up to date if the refactor affects the user experience or the codebase

Pull request related list:

  • No other PR is open related to this refactoring
  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • The PR description is cleaned and ready for merge

@lpsaavedra lpsaavedra changed the title Change default coarse grid solver to direct Change default coarse grid solver for the geometric multigrid Oct 16, 2024
Copy link
Contributor

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, that's a very healthy change I think. Direct is the way to go 90% of the time

@blaisb
Copy link
Contributor

blaisb commented Oct 16, 2024

@lpsaavedra can you add a changelog entry for this since this is a modification to a default parameter?

@blaisb blaisb merged commit 5d96adb into master Oct 16, 2024
11 checks passed
@blaisb blaisb deleted the update_mf_tests branch October 16, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants