Fix simulation restart when using averaging #1300
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an issue where simulation restarts would crash on large parallel simulation when the time-averaging of the velocity was enabled. This issue was caused by the fact that the vectors that were checkpointed were the locally_relevant solutions but the restart was reading into the locally_owned solutions.
Solution
I have fixed this by reading the restart into the locally_relevant solutions. However, I had to add a function to manually sanitize the time_averaging operator because the locally_owned vectors were now empty.
Testing
This should not affect any of the current test results. I do not know if it is necessary to add a new tests since restart tests are cumbersome. @lpsaavedra what do you think?
Documentation
No changes to documentation.
Miscellaneous (will be removed when merged)
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: