-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make vof dcdd optional #1296
Make vof dcdd optional #1296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure it's a good idea to change the default behavior to no dcdd. Let's keep it enabled (it's been enabled for a year now) and until we figure out when it's good and when it's bad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done :) It's good to have the option now!
41dfa52
to
964dc51
Compare
Description It was noticed that using the discontinuity-capturing directional dissipation (DCDD) stabilization was not necessarily helpful for all VOF simulations. With this PR, the stabilization term is now optional. It can be enabled/disabled with the help of a boolean parameter (vof dcdd stabilization) in the stabilization subsection. Former-commit-id: 19c5119
Description It was noticed that using the discontinuity-capturing directional dissipation (DCDD) stabilization was not necessarily helpful for all VOF simulations. With this PR, the stabilization term is now optional. It can be enabled/disabled with the help of a boolean parameter (vof dcdd stabilization) in the stabilization subsection. Former-commit-id: 19c5119
Description
It was noticed that using the discontinuity-capturing directional dissipation (DCDD) stabilization was not necessarily helpful for all VOF simulations. With this PR, the stabilization term is now optional. It can be enabled/disabled with the help of a boolean parameter (
vof dcdd stabilization
) in thestabilization
subsection.Testing
All failing tests because of the disabled DCDD stabilization term were updated and a new application test (
gls_droplet_marangoni_effect_with_dcdd_stabilization
) has been added with the stabilization enabled.Documentation
Stabilization documentation has been updated.
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: