Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vof dcdd optional #1296

Merged
merged 9 commits into from
Sep 26, 2024
Merged

Make vof dcdd optional #1296

merged 9 commits into from
Sep 26, 2024

Conversation

AmishgaAlphonius
Copy link
Collaborator

@AmishgaAlphonius AmishgaAlphonius commented Sep 26, 2024

Description

It was noticed that using the discontinuity-capturing directional dissipation (DCDD) stabilization was not necessarily helpful for all VOF simulations. With this PR, the stabilization term is now optional. It can be enabled/disabled with the help of a boolean parameter (vof dcdd stabilization) in the stabilization subsection.

Testing

All failing tests because of the disabled DCDD stabilization term were updated and a new application test (gls_droplet_marangoni_effect_with_dcdd_stabilization) has been added with the stabilization enabled.

Documentation

Stabilization documentation has been updated.

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Lethe documentation is up to date
  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent
  • If parameters are modified, the tests and the documentation of examples are up to date
  • Changelog (CHANGELOG.md) is up to date if the refactor affects the user experience or the codebase

Pull request related list:

  • No other PR is open related to this refactoring
  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If any future works is planed, an issue is opened
  • The PR description is cleaned and ready for merge

@AmishgaAlphonius AmishgaAlphonius added the Refactoring This PR is only refactoring or clean up label Sep 26, 2024
@AmishgaAlphonius AmishgaAlphonius self-assigned this Sep 26, 2024
@AmishgaAlphonius AmishgaAlphonius marked this pull request as ready for review September 26, 2024 11:54
source/core/parameters.cc Outdated Show resolved Hide resolved
source/core/parameters.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure it's a good idea to change the default behavior to no dcdd. Let's keep it enabled (it's been enabled for a year now) and until we figure out when it's good and when it's bad.

Copy link
Collaborator

@hepap hepap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done :) It's good to have the option now!

doc/source/parameters/cfd/stabilization.rst Outdated Show resolved Hide resolved
doc/source/parameters/cfd/stabilization.rst Outdated Show resolved Hide resolved
doc/source/parameters/cfd/stabilization.rst Outdated Show resolved Hide resolved
include/solvers/vof_assemblers.h Outdated Show resolved Hide resolved
include/solvers/vof_assemblers.h Outdated Show resolved Hide resolved
source/core/parameters.cc Outdated Show resolved Hide resolved
@blaisb blaisb merged commit 19c5119 into master Sep 26, 2024
11 checks passed
@blaisb blaisb deleted the make-vof-dcdd-optional branch September 26, 2024 19:04
blaisb pushed a commit that referenced this pull request Sep 27, 2024
Description
It was noticed that using the discontinuity-capturing directional dissipation (DCDD) stabilization was not necessarily helpful for all VOF simulations. With this PR, the stabilization term is now optional. It can be enabled/disabled with the help of a boolean parameter (vof dcdd stabilization) in the stabilization subsection.



Former-commit-id: 19c5119
blaisb pushed a commit that referenced this pull request Sep 30, 2024
Description
It was noticed that using the discontinuity-capturing directional dissipation (DCDD) stabilization was not necessarily helpful for all VOF simulations. With this PR, the stabilization term is now optional. It can be enabled/disabled with the help of a boolean parameter (vof dcdd stabilization) in the stabilization subsection.



Former-commit-id: 19c5119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for review Rebased Refactoring This PR is only refactoring or clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants