Correct update of solutions for multiphysics in matrix-free application #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaisb
reviewed
Sep 25, 2024
lpsaavedra
force-pushed
the
fix_tracer_with_mf
branch
from
085a27a to
fd1213a
Compare
blaisb
approved these changes
Sep 26, 2024
blaisb
pushed a commit
that referenced
this pull request
Sep 27, 2024
…on (#1294) Description The matrix free application was updating the results outside of the iterate loop. This works only if the other physics are solved before the fluid dynamics, but we have other physics that are solved right after the fluid dynamics and in that case, they need the most recent fluid information within the iterate loop. Solution In order to fix this, we have to update the solutions right after solving the problem for the fluid dynamics, i.e., within the iterate loop right after solve_non_linear_system is called. For this, a function had to be created in the parent class NavierStokesBase. Testing No test available at the moment, the behaviour of the matrix-free application with the other physics is still a work in progress. Former-commit-id: fb2d6f0
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
…on (#1294) Description The matrix free application was updating the results outside of the iterate loop. This works only if the other physics are solved before the fluid dynamics, but we have other physics that are solved right after the fluid dynamics and in that case, they need the most recent fluid information within the iterate loop. Solution In order to fix this, we have to update the solutions right after solving the problem for the fluid dynamics, i.e., within the iterate loop right after solve_non_linear_system is called. For this, a function had to be created in the parent class NavierStokesBase. Testing No test available at the moment, the behaviour of the matrix-free application with the other physics is still a work in progress. Former-commit-id: fb2d6f0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The matrix free application was updating the results outside of the iterate loop. This works only if the other physics are solved before the fluid dynamics, but we have other physics that are solved right after the fluid dynamics and in that case, they need the most recent fluid information within the iterate loop.
Solution
In order to fix this, we have to update the solutions right after solving the problem for the fluid dynamics, i.e., within the iterate loop right after
solve_non_linear_systemis called. For this, a function had to be created in the parent classNavierStokesBase.Testing
No test available at the moment, the behaviour of the matrix-free application with the other physics is still a work in progress.
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: