Added DCDD from previous gradient #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguevremont
added
Enhancement
blaisb
reviewed
Sep 25, 2024
source/solvers/tracer_assemblers.cc
Outdated
Comment on lines
46
to
50
| // We use the previous concentration for the shock capture | ||
| const Tensor<1, dim> previous_tracer_gradient = | ||
| scratch_data.previous_tracer_gradients[q]; | ||
|
|
||
| const double tracer_gradient_norm = previous_tracer_gradient.norm(); |
There was a problem hiding this comment.
This should only be done when the simulation is transient
blaisb
reviewed
Sep 25, 2024
source/solvers/tracer_assemblers.cc
Outdated
Comment on lines
174
to
180
| const double vdcdd = (0.5 * h) * (velocity.norm() * velocity.norm()) * | ||
| pow(tracer_gradient.norm() * h, order); | ||
| pow(tracer_gradient_norm * h, order); | ||
|
|
||
| const double tolerance = 1e-12; | ||
| Tensor<1, dim> s = velocity / (velocity.norm() + tolerance); | ||
| Tensor<1, dim> r = tracer_gradient / (tracer_gradient.norm() + tolerance); | ||
| Tensor<1, dim> r = | ||
| previous_tracer_gradient / (tracer_gradient_norm + tolerance); |
There was a problem hiding this comment.
Again should only be done for transient simulations
oguevremont
added
Ready for review
and removed
WIP
hepap
reviewed
Sep 26, 2024
oguevremont
force-pushed
the
tracer_explicit_dcdd
branch
from
b9084a4 to
4089083
Compare
blaisb
approved these changes
Sep 26, 2024
hepap
approved these changes
Sep 26, 2024
blaisb
pushed a commit
that referenced
this pull request
Sep 27, 2024
Description Previously, the tracer physics used the current time tracer gradient to compute the DCDD stabilization. Using the previous time gradient instead allows to reduce the number of non-linear iterations while still converging to proper solutions. Testing All tests still pass. Documentation Not applicable. Former-commit-id: c2c8cfd
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description Previously, the tracer physics used the current time tracer gradient to compute the DCDD stabilization. Using the previous time gradient instead allows to reduce the number of non-linear iterations while still converging to proper solutions. Testing All tests still pass. Documentation Not applicable. Former-commit-id: c2c8cfd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the tracer physics used the current time tracer gradient to compute the DCDD stabilization. Using the previous time gradient instead allows to reduce the number of non-linear iterations while still converging to proper solutions.
Testing
All tests still pass.
Documentation
Not applicable.
Miscellaneous (will be removed when merged)
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: