Add verbosity to interface thickness in Cahn-Hilliard (and CHNS) solver #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreLaurentinCS
added
Enhancement
AmishgaAlphonius
requested changes
Sep 25, 2024
applications_tests/lethe-fluid/cahn_hilliard_epsilon_verbosity.prm
Outdated
Show resolved
Hide resolved
applications_tests/lethe-fluid/cahn_hilliard_epsilon_verbosity.prm
Outdated
Show resolved
Hide resolved
PierreLaurentinCS
force-pushed
the
chns_epsilon_verbosity
branch
from
553a368 to
1600392
Compare
AmishgaAlphonius
approved these changes
Sep 25, 2024
blaisb
requested changes
Sep 25, 2024
Co-authored-by: Amishga Alphonius <[email protected]>
PierreLaurentinCS
force-pushed
the
chns_epsilon_verbosity
branch
from
d598d4f to
abe293b
Compare
blaisb
approved these changes
Sep 26, 2024
blaisb
pushed a commit
that referenced
this pull request
Sep 27, 2024
…er (#1291) Description It is often useful for the user to know the exact value of the interface thickness when it is determined automatically. Hence a verbosity parameter was added to the interface thickness parameter to display it at every iteration and make sure it remains coherent with the problem under study. Testing An application test was added to make sure any future change to the code do not break the interface thickness computation (whether in deal.ii or lethe) Co-authored-by: Amishga Alphonius <[email protected]> Former-commit-id: 9d43a28
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
…er (#1291) Description It is often useful for the user to know the exact value of the interface thickness when it is determined automatically. Hence a verbosity parameter was added to the interface thickness parameter to display it at every iteration and make sure it remains coherent with the problem under study. Testing An application test was added to make sure any future change to the code do not break the interface thickness computation (whether in deal.ii or lethe) Co-authored-by: Amishga Alphonius <[email protected]> Former-commit-id: 9d43a28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is often useful for the user to know the exact value of the interface thickness when it is determined automatically. Hence a verbosity parameter was added to the interface thickness parameter to display it at every iteration and make sure it remains coherent with the problem under study.
Testing
An application test was added to make sure any future change to the code do not break the interface thickness computation (whether in deal.ii or lethe)
Documentation
This pull requests adds a new parameter in the Cahn-Hilliard subsection of the .prm file. The documentation was modified accordingly and also made clearer.
Code related list:
Pull request related list: