Modify cell diameter function #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmishgaAlphonius
force-pushed
the
modify-cell-diameter-function
branch
from
19f8673 to
1134b76
Compare
blaisb
force-pushed
the
modify-cell-diameter-function
branch
from
3645253 to
64800d6
Compare
AmishgaAlphonius
force-pushed
the
modify-cell-diameter-function
branch
from
64800d6 to
a1b73cd
Compare
oguevremont
reviewed
Sep 11, 2024
oguevremont
approved these changes
Sep 12, 2024
AmishgaAlphonius
force-pushed
the
modify-cell-diameter-function
branch
from
17596ec to
6c01677
Compare
blaisb
requested changes
Sep 12, 2024
|
is this ready to review @AmishgaAlphonius ? |
Yes :) |
blaisb
approved these changes
Sep 13, 2024
OGaboriault
pushed a commit
that referenced
this pull request
Sep 17, 2024
Description The previous implementation to calculate cell diameter used the measure function which assumed a linear mapping. Solution This PR adds a function that calculates the volume by integrating 1 over the cell, by summing JxW values returned by the FEValues object. Testing Tests that were outdated have been updated.
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description The previous implementation to calculate cell diameter used the measure function which assumed a linear mapping. Solution This PR adds a function that calculates the volume by integrating 1 over the cell, by summing JxW values returned by the FEValues object. Testing Tests that were outdated have been updated. Former-commit-id: 0430787
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description The previous implementation to calculate cell diameter used the measure function which assumed a linear mapping. Solution This PR adds a function that calculates the volume by integrating 1 over the cell, by summing JxW values returned by the FEValues object. Testing Tests that were outdated have been updated. Former-commit-id: 0430787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous implementation to calculate cell diameter used the
measurefunction which assumed a linear mapping.Solution
This PR adds a function that calculates the volume by integrating 1 over the cell, by summing JxW values returned by the FEValues object.
Testing
Tests that were outdated have been updated.
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: