Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non zero constraints distribution amongst processes #1278

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

oguevremont
Copy link
Collaborator

@oguevremont oguevremont commented Sep 10, 2024

Description

When running large scale simulations involving the tracer physics, an issue of lack of memory arose. This issue didn't happen when only fluid dynamics or heat transfer physics were solved; only tracer.

Solution

By comparing implementation in other auxiliary physics, it appeared that non-zero constraints were not reinitialized with locally relevant DOFs. This was fixed.

Testing

Large scale tracer simulations now run without lack of memory, with fluid dynamics active or not. All tests still pass.

Documentation

No documentation change needed.

Miscellaneous (will be removed when merged)

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Lethe documentation is up to date
  • Fix has unit test(s) (preferred) or application test(s), and restart files are in the generator folder
  • The branch is rebased onto master
  • Changelog (CHANGELOG.md) is up to date
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If the fix is temporary, an issue is opened
  • The PR description is cleaned and ready for merge

@oguevremont oguevremont added Bug Something isn't working WIP When a PR is open but not ready for review labels Sep 10, 2024
@oguevremont oguevremont added Ready for review and removed WIP When a PR is open but not ready for review labels Sep 10, 2024
@oguevremont oguevremont requested a review from blaisb September 10, 2024 14:52
@blaisb blaisb merged commit ef79e49 into master Sep 10, 2024
11 checks passed
@blaisb blaisb deleted the fix_distribution_tracer branch September 10, 2024 14:56
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024
…l#1278)

Description
When running large scale simulations involving the tracer physics, an issue of lack of memory arose. This issue didn't happen when only fluid dynamics or heat transfer physics were solved; only tracer.

Solution
By comparing implementation in other auxiliary physics, it appeared that non-zero constraints were not reinitialized with locally relevant DOFs. This was fixed.

Former-commit-id: ef79e49
blaisb pushed a commit that referenced this pull request Sep 30, 2024
Description
When running large scale simulations involving the tracer physics, an issue of lack of memory arose. This issue didn't happen when only fluid dynamics or heat transfer physics were solved; only tracer.

Solution
By comparing implementation in other auxiliary physics, it appeared that non-zero constraints were not reinitialized with locally relevant DOFs. This was fixed.

Former-commit-id: ef79e49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants