Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation for mesh parameters #1277

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Added documentation for mesh parameters #1277

merged 2 commits into from
Sep 9, 2024

Conversation

oguevremont
Copy link
Collaborator

@oguevremont oguevremont commented Sep 9, 2024 •
edited
Loading

Description

Some parameters in the Mesh subsection were not documentation. This PR adds the missing documentation.

Miscellaneous (will be removed when merged)

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Lethe documentation is up to date
  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If any future works is planed, an issue is opened
  • The PR description is cleaned and ready for merge

@blaisb
Copy link
Contributor

blaisb commented Sep 9, 2024

@oguevremont can you add a changelog entry please?

@blaisb blaisb merged commit 713c28f into master Sep 9, 2024
11 checks passed
@blaisb blaisb deleted the doc_mesh_reading branch September 9, 2024 19:23
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024
@oguevremont
Added documentation for mesh parameters (chaos-polymtl#1277)
1f521ad 
Description
Some parameters in the Mesh subsection were not documentation. This PR adds the missing documentation.

Former-commit-id: 713c28f
blaisb pushed a commit that referenced this pull request Sep 30, 2024
@oguevremont
Added documentation for mesh parameters (#1277)
b20b048 
Description
Some parameters in the Mesh subsection were not documentation. This PR adds the missing documentation.

Former-commit-id: 713c28f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blaisb blaisb blaisb approved these changes

@Julamipolymtl Julamipolymtl Awaiting requested review from Julamipolymtl

Assignees
No one assigned
Labels
Documentation Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oguevremont @blaisb