Add new scaling parameters for the Cahn-Hilliard model #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreLaurentinCS
added
Enhancement
PierreLaurentinCS
added
Ready for review
and removed
Needs more reviewers
hepap
reviewed
Sep 9, 2024
| @@ -353,7 +353,8 @@ namespace Parameters | |||
| void | |||
| declare_parameters(ParameterHandler &prm); | |||
| void | |||
| parse_parameters(ParameterHandler &prm); | |||
| parse_parameters(ParameterHandler &prm, | |||
There was a problem hiding this comment.
I know it was not there initially, but you could add the briefs
| { | ||
| surface_tension_coefficient = prm.get_double("surface tension coefficient"); | ||
| T_0 = prm.get_double("reference state temperature"); | ||
| surface_tension_coefficient *= dimensions.surface_tension_scaling; | ||
| T_0 = prm.get_double("reference state temperature"); |
There was a problem hiding this comment.
T_0 should be scale also I think
There was a problem hiding this comment.
Why aren't the dimensions multiplied in the same line?
source/core/parameters.cc
Outdated
Comment on lines
1346
to
1356
| surface_tension_parameters.parse_parameters(prm, dimensions); | ||
| } | ||
| else if (op == "linear") | ||
| { | ||
| surface_tension_model = SurfaceTensionModel::linear; | ||
| surface_tension_parameters.parse_parameters(prm); | ||
| surface_tension_parameters.parse_parameters(prm, dimensions); | ||
| } | ||
| else if (op == "phase change") | ||
| { | ||
| surface_tension_model = SurfaceTensionModel::phase_change; | ||
| surface_tension_parameters.parse_parameters(prm); | ||
| surface_tension_parameters.parse_parameters(prm, dimensions); |
There was a problem hiding this comment.
Could we just call the parse_parameters once after the if/else ifs/else? Same for CH
voferreira
approved these changes
Sep 12, 2024
| { | ||
| surface_tension_coefficient = prm.get_double("surface tension coefficient"); | ||
| T_0 = prm.get_double("reference state temperature"); | ||
| surface_tension_coefficient *= dimensions.surface_tension_scaling; | ||
| T_0 = prm.get_double("reference state temperature"); |
There was a problem hiding this comment.
Why aren't the dimensions multiplied in the same line?
PierreLaurentinCS
force-pushed
the
chns-dimensionality
branch
from
25e2271 to
e2ff3c0
Compare
PierreLaurentinCS
added
Reviewed and ready to merge
and removed
Ready for review
labels
|
@PierreLaurentinCS can you update the change log? |
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
…#1274) Description With new models come new parameters that need to be dimensionalised adequately when changing the units in the "Dimensionality" section of the parameter file. With the Cahn-Hilliard model, it was the mobility coefficient, the interface thickness and the surface tension. Three new scalings were added at first, for those three parameters. Since surface tension is also used in VOF model, a fourth scaling parameter was added for the surface tension gradient for completion. There was a mistake in the scaling of thermal expansion which was corrected. Testing No testing because it would imply coding an output for the physical properties which is unnecessary. It works fine. Former-commit-id: 46511be
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description With new models come new parameters that need to be dimensionalised adequately when changing the units in the "Dimensionality" section of the parameter file. With the Cahn-Hilliard model, it was the mobility coefficient, the interface thickness and the surface tension. Three new scalings were added at first, for those three parameters. Since surface tension is also used in VOF model, a fourth scaling parameter was added for the surface tension gradient for completion. There was a mistake in the scaling of thermal expansion which was corrected. Testing No testing because it would imply coding an output for the physical properties which is unnecessary. It works fine. Former-commit-id: 46511be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With new models come new parameters that need to be dimensionalised adequately when changing the units in the "Dimensionality" section of the parameter file.
With the Cahn-Hilliard model, it was the mobility coefficient, the interface thickness and the surface tension.
Three new scalings were added at first, for those three parameters. Since surface tension is also used in VOF model, a fourth scaling parameter was added for the surface tension gradient for completion.
There was a mistake in the scaling of thermal expansion which was corrected.
Testing
No testing because it would imply coding an output for the physical properties which is unnecessary.It works fine.
Documentation
No new documentation
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: