Make dcdd shock capture optional for heat transfer #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaisb
requested changes
Aug 29, 2024
…n. updated doc and modified source code
mivaia
force-pushed
the
make_dcdd_shock_capture_optional_for_heat_transfer
branch
from
75a1a3b to
4b9d295
Compare
blaisb
approved these changes
Aug 29, 2024
voferreira
reviewed
Aug 30, 2024
…ttps://github.com/chaos-polymtl/lethe into make_dcdd_shock_capture_optional_for_heat_transfer
|
@mivaia an advice please rebase master onto your branch instead of merging next time. We always wish to avoid merge commits. |
blaisb
reviewed
Sep 7, 2024
blaisb
approved these changes
Sep 7, 2024
|
Will merge after CI has passed |
blaisb
added
Reviewed and ready to merge
and removed
Reviewed and waiting for changes
labels
blaisb
deleted the
make_dcdd_shock_capture_optional_for_heat_transfer
branch
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description DCDD stabilization was always used for the heat equation. DCDD usage sometimes lead to results that were not expected. More investigation will be needed in the future to understand what is the effect of adding the DCDD stabilization. DCDD is now disabled by default. A new assembler has been created in order to take it into account. Testing Modified existing tests using heat transfer. Co-authored-by: Bruno Blais <[email protected]> Former-commit-id: b6090ce
blaisb
added a commit
that referenced
this pull request
Sep 30, 2024
Description DCDD stabilization was always used for the heat equation. DCDD usage sometimes lead to results that were not expected. More investigation will be needed in the future to understand what is the effect of adding the DCDD stabilization. DCDD is now disabled by default. A new assembler has been created in order to take it into account. Testing Modified existing tests using heat transfer. Co-authored-by: Bruno Blais <[email protected]> Former-commit-id: b6090ce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DCDD stabilization was always used for the heat equation. DCDD usage sometimes lead to results that were not expected. More investigation will be needed in the future to understand what is the effect of adding the DCDD stabilization.
DCDD is now disabled by default. A new assembler has been created in order to take it into account.
Testing
Modified existing tests using heat transfer.
Documentation
Added a set DCDD shock capture option in the multiphysics section.
Miscellaneous (will be removed when merged)
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: