-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print parameters (lethe-fluid-matrix-free) #1255
Conversation
I am not sure what is your goal here. All the parameters in Lethe are documented in the following webpage I would refrain from duplicating information sources / locations. I don,t want to get to a point where we print the prm file whenever we are launching a job. There is already a parameter template generator executable. I know there are many parameters, but there is no way around this. |
The idea is to print all relevant parameters at the end of the simulation. We can add a parameter to enable/disable this, but having the simulation output and the chosen parameters next to each other/in the same file is quite useful in my opinion. If you run too many parameter studies you loose the overview of the modified parameters. |
Sure that's a good idea. However it would be relevant to add the switch right now, otherwise all tests will explode for the moment being. Maybe add a runtime option --print-parameters to the executable. In that case it would print the parameters, otherwise it would be the regular behavior. Then we could implement the same behavior for all solvers because I think it would be very useful. It's a cool feature |
@blaisb What do you think about the last commit? |
I love the last commit. That's a very nice way to do it. |
@blaisb Done! |
Print all relevant parameters at the end of the simulation. We can add a parameter to enable/disable this, but having the simulation output and the chosen parameters next to each other/in the same file is quite useful in my opinion. If you run too many parameter studies you loose the overview of the modified parameters. Former-commit-id: 4f256b3
Print all relevant parameters at the end of the simulation. We can add a parameter to enable/disable this, but having the simulation output and the chosen parameters next to each other/in the same file is quite useful in my opinion. If you run too many parameter studies you loose the overview of the modified parameters. Former-commit-id: 4f256b3
The output is like this:
Only the changed parameters are printed (Lethe just has too many parameters).
depends on dealii/dealii#17593