Update turbulent taylor couette time stepping in example #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpsaavedra
requested changes
Aug 8, 2024
...rce/examples/incompressible-flow/3d-turbulent-taylor-couette/3d-turbulent-taylor-couette.rst
Outdated
Show resolved
Hide resolved
...ples/incompressible-flow/3d-turbulent-taylor-couette/images/enstrophy_comparison_655k_Q2.png
Outdated
Show resolved
Hide resolved
examples/incompressible-flow/3d-turbulent-taylor-couette/tc-matrix-free.prm
Outdated
Show resolved
Hide resolved
|
I applied all of your comments @lpsaavedra |
lpsaavedra
approved these changes
Aug 8, 2024
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
…tl#1235) Description The Taylor-Couette example was using constant time-stepping and a BDF3 time-integrator. This is not a good practice for this example. I have updated the parameter file, the prm file and also the .png files of the results. The new results are much better especially for fine meshes. Former-commit-id: e27c86c
blaisb
added a commit
that referenced
this pull request
Sep 30, 2024
Description The Taylor-Couette example was using constant time-stepping and a BDF3 time-integrator. This is not a good practice for this example. I have updated the parameter file, the prm file and also the .png files of the results. The new results are much better especially for fine meshes. Former-commit-id: e27c86c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Taylor-Couette example was using constant time-stepping and a BDF3 time-integrator. This is not a good practice for this example. I have updated the parameter file, the prm file and also the .png files of the results. The new results are much better especially for fine meshes.
Code related list:
Pull request related list: