-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PID mesh adaptation quick fix #1229
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t. ->added initial condition parameter file, erased multiphysics use average velocity profile, modified the read_checkpoint to take into account, set simulation time to 0 and erased precedent pvd info
…was not being solved. Changed some conditions to take this into account
…y as an initial condition has a bdf time stepping scheme
…estart with the initial condition. Scaling bug in average velocity
…on for restart and initial condition
…e previously not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialized previous_mesh_controller and previous number of elements to 0 in the constructor of the mesh controller object.
Description
previous_mesh_control_error which controls the intregral part of the error was not initialized. This affected geatly the PID controller convergence because really high values would sometimes be attributed at start to previous_mesh_control_error.
Solution
Initialized the value in the constructor.
Testing
Old tests were kept.
Documentation
Miscellaneous (will be removed when merged)
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: