Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all files related to the VANS solver using Fluid Dynamics prefix #1225

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

lpsaavedra
Copy link
Collaborator

@lpsaavedra lpsaavedra commented Aug 5, 2024

Description

This PR changes the name of the main class and the name of the files related to the lethe-fluid-vans application. Is the second PR on a series of PRs that aim to rename all the Navier Stokes solvers of Lethe using the prefix FluidDynamics and removing GLS.

Testing

All the existent tests pass without any change.

Miscellaneous (will be removed when merged)

  • The name of all the VANS assemblers had to be modified as well so that everything is uniform.

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Lethe documentation is up to date
  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent
  • Changelog (CHANGELOG.md) is up to date if the refactor affects the user experience or the codebase

Pull request related list:

  • No other PR is open related to this refactoring
  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • The PR description is cleaned and ready for merge

@lpsaavedra lpsaavedra self-assigned this Aug 5, 2024
@blaisb blaisb merged commit f87d2d1 into master Aug 6, 2024
8 checks passed
@blaisb blaisb deleted the rename_vans branch August 6, 2024 00:07
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024
…ix (chaos-polymtl#1225)

Description
This PR changes the name of the main class and the name of the files related to the lethe-fluid-vans application. Is the second PR on a series of PRs that aim to rename all the Navier Stokes solvers of Lethe using the prefix FluidDynamics and removing GLS.

Testing
All the existent tests pass without any change.

Former-commit-id: f87d2d1
blaisb pushed a commit that referenced this pull request Sep 30, 2024
…ix (#1225)

Description
This PR changes the name of the main class and the name of the files related to the lethe-fluid-vans application. Is the second PR on a series of PRs that aim to rename all the Navier Stokes solvers of Lethe using the prefix FluidDynamics and removing GLS.

Testing
All the existent tests pass without any change.

Former-commit-id: f87d2d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants