Allow to iterate intermediate GMG levels #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaisb
reviewed
Jul 30, 2024
There was a problem hiding this comment.
I'm OK with this, but it also lacks the associated documentation. @lpsaavedra I'll let you take a look first
peterrum
force-pushed
the
mg_intermediate
branch
2 times, most recently
from
e243868 to
c34c49a
Compare
lpsaavedra
approved these changes
Jul 31, 2024
lpsaavedra
force-pushed
the
mg_intermediate
branch
from
c34c49a to
7a47b8e
Compare
|
I added the new parameter in the documentation and updated the changelog. Let us test it before introducing more parameters. |
8 tasks
blaisb
pushed a commit
that referenced
this pull request
Aug 27, 2024
Description In PR #1211 a new parameter was introduced that allow to iterate intermediate GMG levels. This allows to choose a level as coarse grid and used there a GMRES iterative solver preconditioned by a MG. So far, only one parameter was present: mg int level, however, the parameters for the number of iterations and tolerances were being hardcoded. This PR changes that by using already existing GMRES parameters.. Testing I have tested this in the flow around a sphere case and seems to work just fine. Documentation The documentation was updated by adding a note that specifies the use of these parameters for this purpose as well.
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Co-authored-by: Laura Prieto Saavedra <[email protected]> Former-commit-id: e134727
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
…os-polymtl#1264) Description In PR chaos-polymtl#1211 a new parameter was introduced that allow to iterate intermediate GMG levels. This allows to choose a level as coarse grid and used there a GMRES iterative solver preconditioned by a MG. So far, only one parameter was present: mg int level, however, the parameters for the number of iterations and tolerances were being hardcoded. This PR changes that by using already existing GMRES parameters.. Testing I have tested this in the flow around a sphere case and seems to work just fine. Documentation The documentation was updated by adding a note that specifies the use of these parameters for this purpose as well. Former-commit-id: bf39a0d
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Co-authored-by: Laura Prieto Saavedra <[email protected]> Former-commit-id: e134727
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description In PR #1211 a new parameter was introduced that allow to iterate intermediate GMG levels. This allows to choose a level as coarse grid and used there a GMRES iterative solver preconditioned by a MG. So far, only one parameter was present: mg int level, however, the parameters for the number of iterations and tolerances were being hardcoded. This PR changes that by using already existing GMRES parameters.. Testing I have tested this in the flow around a sphere case and seems to work just fine. Documentation The documentation was updated by adding a note that specifies the use of these parameters for this purpose as well. Former-commit-id: bf39a0d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.