-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ASM as preconditioner of smoother #1210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First batch of comments, will continue reviewing later
@@ -44,6 +45,209 @@ | |||
|
|||
#include <deal.II/numerics/vector_tools.h> | |||
|
|||
template <typename VectorType> | |||
class PreconditionBase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why you want to declare the class just in the .cc and not in the .h upstream?
Also, can you add @brief and documentation for the base class following doxygen syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why you want to declare the class just in the .cc and not in the .h upstream?
I would like to keep this local here as long as it is not needed anywhere else.
Also, can you add @brief and documentation for the base class following doxygen syntax.
Done!
PreconditionASM() | ||
: weighting_type(WeightingType::left) | ||
{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So right now this is still a prototype class I presume right (because the weighting type of hardcoded).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So right now this is still a prototype class I presume right (because the weighting type of hardcoded).
Yes its still a prototype. I need to make some clean up; but the version here should be enough to conduct some first experiments.
For the weighting type, one probably does not need any parameter, since the others don't really work in the NS context (I wrote the original implementation for a Poisson operator where the other variants worked better).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, good for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me! I am excited to try it out. I have only two minor comments... should we add this to the documentation? Or since it is a prototype, should we test it first? What do you think?
@lpsaavedra this is very prototype-ish. Let's test it first |
Co-authored-by: Laura Prieto Saavedra <[email protected]> Former-commit-id: 9c18482
Co-authored-by: Laura Prieto Saavedra <[email protected]> Former-commit-id: 9c18482
No description provided.