Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add different variants of p-multgrid #1209

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Add different variants of p-multgrid #1209

merged 4 commits into from
Jul 31, 2024

Conversation

peterrum
Copy link
Collaborator

No description provided.

@peterrum peterrum requested review from blaisb and lpsaavedra July 27, 2024 19:41
Copy link
Contributor

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me this is good. @lpsaavedra could you add the .rst documentation so that the new feature is documented? This will be very cool!

include/core/parameters.h Show resolved Hide resolved
prm.declare_entry("mg p coarsening type",
"decrease by one",
Patterns::Selection(
"decrease by one|bisect|go to one"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is bisect?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the deal.II documentation:

Screenshot from 2024-07-30 19-47-19

@blaisb
Copy link
Contributor

blaisb commented Jul 31, 2024

@lpsaavedra you want to do the documentation in this PR or you want to regroup the new docs in another PR?

@lpsaavedra
Copy link
Collaborator

lpsaavedra commented Jul 31, 2024

I have now added the documentation for the new strategies in this PR and it is ready to be reviewed

@blaisb blaisb merged commit 91608d7 into master Jul 31, 2024
8 checks passed
@blaisb blaisb deleted the pmg branch July 31, 2024 18:47
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024

Co-authored-by: Laura Prieto Saavedra <[email protected]>
Co-authored-by: Laura Prieto Saavedra <[email protected]>
Co-authored-by: Bruno Blais <[email protected]>
Former-commit-id: 91608d7
blaisb added a commit that referenced this pull request Sep 30, 2024

Co-authored-by: Laura Prieto Saavedra <[email protected]>
Co-authored-by: Laura Prieto Saavedra <[email protected]>
Co-authored-by: Bruno Blais <[email protected]>
Former-commit-id: 91608d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants