Regenerate clean application test outputs in DEM and CFD-DEM #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdaigneault
commented
Jul 25, 2024
|
|
||
| ******************************************************************************* | ||
| Transient iteration: 2 Time: 0.002 Time step: 0.001 CFL: 1.39637 | ||
| Transient iteration: 2 Time: 0.002 Time step: 0.001 CFL: 1.39637 |
There was a problem hiding this comment.
Here are the changes of this test after enabling particle statistics
acdaigneault
commented
Jul 25, 2024
There was a problem hiding this comment.
I changed the output, but the test is disabled...
acdaigneault
commented
Jul 25, 2024
| @@ -1406,6 +1406,9 @@ CFDDEMSolver<dim>::dem_setup_contact_parameters() | |||
| break; | |||
| } | |||
| } | |||
|
|
|||
| // Initialize the total contact list counter | |||
| contact_search_total_number = 0; | |||
There was a problem hiding this comment.
This was not initialized, so the first number in the stats was wrong (and kinda random)
blaisb
approved these changes
Jul 26, 2024
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
…olymtl#1207) Description The application test outputs had some extra spaces or some missing spaces, making it appears in diff of files when the output is updated and put them back or remove them. It makes it hard to focus on the real changes of the test. Also, some strings in CFD-DEM did have spaces for no reason. Solution Remove the explicit spaces in CFD-DEM and regenerate all the tests in DEM and CFD-DEM from the real output files of tests (no copy-paste). Testing All tests are the same. I added particle statistic output to spouted_bed_load_balancing test for more robust testing in CFD-DEM. Former-commit-id: cda1644
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description The application test outputs had some extra spaces or some missing spaces, making it appears in diff of files when the output is updated and put them back or remove them. It makes it hard to focus on the real changes of the test. Also, some strings in CFD-DEM did have spaces for no reason. Solution Remove the explicit spaces in CFD-DEM and regenerate all the tests in DEM and CFD-DEM from the real output files of tests (no copy-paste). Testing All tests are the same. I added particle statistic output to spouted_bed_load_balancing test for more robust testing in CFD-DEM. Former-commit-id: cda1644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The application test outputs had some extra spaces or some missing spaces, making it appears in diff of files when the output is updated and put them back or remove them. It makes it hard to focus on the real changes of the test.
Also, some strings in CFD-DEM did have spaces for no reason.
Solution
Remove the explicit spaces in CFD-DEM and regenerate all the tests in DEM and CFD-DEM from the real output files of tests (no copy-paste).
Testing
All tests are the same.
I added particle statistic output to
spouted_bed_load_balancingtest for more robust testing in CFD-DEM.Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: