-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor improvements in multigrid time summary #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpsaavedra
changed the title
Correct minor issues in multigrid time summary
Minor improvements in multigrid time summary
Jul 11, 2024
peterrum
approved these changes
Jul 11, 2024
blaisb
approved these changes
Jul 12, 2024
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description This PR adds the workload_imbalance(...) and the vertical_communication_efficiency(..) calls to output important information for the comparison of the local smoothing and global coarsening approaches. In addition, minor problems related to MG output were found: The timers for mg detailed times were created by specifying the MPI Communicator, however, this does not output the correct min, max and average times. The initial condition time was somehow overlapping with other timers. The update_multiphysics_time_average_solution() was being called when the meshes were refined, however, this is only needed if more than one physics is active. Solution The MG timers are now constructed without the MPI communicator. An independent timer was created for the ramp initial condition and it prints the wall time at the end of the ramp. An if condition checks whether other physics are active. The last two were solved for both the matrix-based and matrix-free application. Testing This was tested locally by using the benchmarks for locally refined meshes. Documentation Nothing needs to be modified. Former-commit-id: ba68bfd
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description This PR adds the workload_imbalance(...) and the vertical_communication_efficiency(..) calls to output important information for the comparison of the local smoothing and global coarsening approaches. In addition, minor problems related to MG output were found: The timers for mg detailed times were created by specifying the MPI Communicator, however, this does not output the correct min, max and average times. The initial condition time was somehow overlapping with other timers. The update_multiphysics_time_average_solution() was being called when the meshes were refined, however, this is only needed if more than one physics is active. Solution The MG timers are now constructed without the MPI communicator. An independent timer was created for the ramp initial condition and it prints the wall time at the end of the ramp. An if condition checks whether other physics are active. The last two were solved for both the matrix-based and matrix-free application. Testing This was tested locally by using the benchmarks for locally refined meshes. Documentation Nothing needs to be modified. Former-commit-id: ba68bfd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
workload_imbalance(...)
and thevertical_communication_efficiency(..)
calls to output important information for the comparison of the local smoothing and global coarsening approaches.In addition, minor problems related to MG output were found:
update_multiphysics_time_average_solution()
was being called when the meshes were refined, however, this is only needed if more than one physics is active.Solution
The last two were solved for both the matrix-based and matrix-free application.
Testing
This was tested locally by using the benchmarks for locally refined meshes.
Documentation
Nothing needs to be modified.
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: