Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements in multigrid time summary #1194

Merged
merged 7 commits into from
Jul 12, 2024
Merged

Minor improvements in multigrid time summary #1194

merged 7 commits into from
Jul 12, 2024

Conversation

lpsaavedra
Copy link
Collaborator

@lpsaavedra lpsaavedra commented Jul 11, 2024

Description

This PR adds the workload_imbalance(...) and the vertical_communication_efficiency(..) calls to output important information for the comparison of the local smoothing and global coarsening approaches.

In addition, minor problems related to MG output were found:

  1. The timers for mg detailed times were created by specifying the MPI Communicator, however, this does not output the correct min, max and average times.
  2. The initial condition time was somehow overlapping with other timers.
  3. The update_multiphysics_time_average_solution() was being called when the meshes were refined, however, this is only needed if more than one physics is active.

Solution

  1. The MG timers are now constructed without the MPI communicator.
  2. An independent timer was created for the ramp initial condition and it prints the wall time at the end of the ramp.
  3. An if condition checks whether other physics are active.

The last two were solved for both the matrix-based and matrix-free application.

Testing

This was tested locally by using the benchmarks for locally refined meshes.

Documentation

Nothing needs to be modified.

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • The branch is rebased onto master
  • Changelog (CHANGELOG.md) is up to date
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • The PR description is cleaned and ready for merge

@lpsaavedra lpsaavedra changed the title Correct minor issues in multigrid time summary Minor improvements in multigrid time summary Jul 11, 2024
@lpsaavedra lpsaavedra requested a review from peterrum July 11, 2024 20:13
@blaisb blaisb merged commit ba68bfd into master Jul 12, 2024
8 checks passed
@blaisb blaisb deleted the mg_info branch July 12, 2024 12:13
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024
Description
This PR adds the workload_imbalance(...) and the vertical_communication_efficiency(..) calls to output important information for the comparison of the local smoothing and global coarsening approaches.

In addition, minor problems related to MG output were found:

The timers for mg detailed times were created by specifying the MPI Communicator, however, this does not output the correct min, max and average times.
The initial condition time was somehow overlapping with other timers.
The update_multiphysics_time_average_solution() was being called when the meshes were refined, however, this is only needed if more than one physics is active.
Solution
The MG timers are now constructed without the MPI communicator.
An independent timer was created for the ramp initial condition and it prints the wall time at the end of the ramp.
An if condition checks whether other physics are active.
The last two were solved for both the matrix-based and matrix-free application.

Testing
This was tested locally by using the benchmarks for locally refined meshes.

Documentation
Nothing needs to be modified.



Former-commit-id: ba68bfd
blaisb pushed a commit that referenced this pull request Sep 30, 2024
Description
This PR adds the workload_imbalance(...) and the vertical_communication_efficiency(..) calls to output important information for the comparison of the local smoothing and global coarsening approaches.

In addition, minor problems related to MG output were found:

The timers for mg detailed times were created by specifying the MPI Communicator, however, this does not output the correct min, max and average times.
The initial condition time was somehow overlapping with other timers.
The update_multiphysics_time_average_solution() was being called when the meshes were refined, however, this is only needed if more than one physics is active.
Solution
The MG timers are now constructed without the MPI communicator.
An independent timer was created for the ramp initial condition and it prints the wall time at the end of the ramp.
An if condition checks whether other physics are active.
The last two were solved for both the matrix-based and matrix-free application.

Testing
This was tested locally by using the benchmarks for locally refined meshes.

Documentation
Nothing needs to be modified.



Former-commit-id: ba68bfd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants