Add plane to stasis constraint and remove pressure constraints #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmishgaAlphonius
added
Bug
AmishgaAlphonius
added
Ready for review
Needs more reviewers
AmishgaAlphonius
changed the title
blaisb
approved these changes
Jul 12, 2024
|
can you rebase? Then I would merge afterwards |
blaisb
added
Reviewed and ready to merge
and removed
Ready for review
Needs more reviewers
…d parameters to ConstrainSolidDomain<dim>
AmishgaAlphonius
force-pushed
the
add-plane-to-stasis-constraint
branch
from
753557e to
6989b50
Compare
|
I'll wait until @oguevremont and @hepap accept the PR before merging |
oguevremont
approved these changes
Jul 15, 2024
AmishgaAlphonius
force-pushed
the
add-plane-to-stasis-constraint
branch
from
52ef1b4 to
653027c
Compare
hepap
approved these changes
Jul 15, 2024
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
…-polymtl#1193) Description Following the implementation of temperature-dependent solid domain constraint for both single-phase and two-phase flows, a need for an additional condition was identified. Indeed, in some simulations, splatters may happen, and with the previous implementation, splatter could freeze "mid-air" which is non-physical and therefore undesired. This PR adds a plane to divide the problem domain in two parts and only the one in the opposite direction to the normal vector is considered for stasis constraints to be applied. The plane is defined through a point and an outward pointing normal vector. During this PR, a bug regarding the pressure constraints was detected and fixed. Previously, the pressure DOFs were also constrained, but this resulted in an ill-posed problem when sources terms in the momentum equation were pressure-dependent. Therefore, as of this PR, the constraints on pressure DOFs were removed. Testing Previous tests with solid domain constraints were updated due to the pressure DOFs that are no more constrained. Additionally, two new application tests were added for the new plane restriction feature (1 for single fluid flows and one for VOF). Documentation The "Constrain Stasis" page in the parameter documentation was updated with the new features and disabled ones. Former-commit-id: c41f675
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description Following the implementation of temperature-dependent solid domain constraint for both single-phase and two-phase flows, a need for an additional condition was identified. Indeed, in some simulations, splatters may happen, and with the previous implementation, splatter could freeze "mid-air" which is non-physical and therefore undesired. This PR adds a plane to divide the problem domain in two parts and only the one in the opposite direction to the normal vector is considered for stasis constraints to be applied. The plane is defined through a point and an outward pointing normal vector. During this PR, a bug regarding the pressure constraints was detected and fixed. Previously, the pressure DOFs were also constrained, but this resulted in an ill-posed problem when sources terms in the momentum equation were pressure-dependent. Therefore, as of this PR, the constraints on pressure DOFs were removed. Testing Previous tests with solid domain constraints were updated due to the pressure DOFs that are no more constrained. Additionally, two new application tests were added for the new plane restriction feature (1 for single fluid flows and one for VOF). Documentation The "Constrain Stasis" page in the parameter documentation was updated with the new features and disabled ones. Former-commit-id: c41f675
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the implementation of temperature-dependent solid domain constraint for both single-phase and two-phase flows, a need for an additional condition was identified. Indeed, in some simulations, splatters may happen, and with the previous implementation, splatter could freeze "mid-air" which is non-physical and therefore undesired. This PR adds a plane to divide the problem domain in two parts and only the one in the opposite direction to the normal vector is considered for stasis constraints to be applied. The plane is defined through a point and an outward pointing normal vector.
During this PR, a bug regarding the pressure constraints was detected and fixed. Previously, the pressure DOFs were also constrained, but this resulted in an ill-posed problem when sources terms in the momentum equation were pressure-dependent. Therefore, as of this PR, the constraints on pressure DOFs were removed.
Testing
Previous tests with solid domain constraints were updated due to the pressure DOFs that are no more constrained.
Additionally, two new application tests were added for the new plane restriction feature (1 for single fluid flows and one for VOF).
Documentation
The "Constrain Stasis" page in the parameter documentation was updated with the new features and disabled ones.
Miscellaneous (will be removed when merged)
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: