Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize NS-VOF assembler #1188

Merged
merged 4 commits into from
Jul 6, 2024
Merged

Optimize NS-VOF assembler #1188

merged 4 commits into from
Jul 6, 2024

Conversation

hepap
Copy link
Collaborator

@hepap hepap commented Jul 5, 2024

Description

The NS-VOF assembler was not optimized as the NS assembler. The if conditions on the dof components were added to not compute multiplications that are a priori 0.

Testing

None of the application tests have changed. The computational time gain is about 20% by iteration on the 3D lpbf benchmark case for a simulation of about 300 iterations. I can do it for a complete simulation if you thing it is worth doing it :)

Documentation

No new documentation needed.

Miscellaneous (will be removed when merged)

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Lethe documentation is up to date
  • New feature has unit test(s) (preferred) or application test(s), and restart files are in the generator folder
  • The branch is rebased onto master
  • Changelog (CHANGELOG.md) is up to date
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If the fix is temporary, an issue is opened
  • The PR description is cleaned and ready for merge

@blaisb blaisb merged commit 51c91aa into master Jul 6, 2024
8 checks passed
@blaisb blaisb deleted the optimize_NS_VOF_assembler branch July 6, 2024 16:42
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024
Description
The NS-VOF assembler was not optimized as the NS assembler. The if conditions on the dof components were added to not compute multiplications that are a priori 0.

Testing
None of the application tests have changed. The computational time gain is about 20% by iteration on the 3D lpbf benchmark case for a simulation of about 300 iterations. I can do it for a complete simulation if you thing it is worth doing it :)

Documentation
No new documentation needed.

Former-commit-id: 51c91aa
blaisb pushed a commit that referenced this pull request Sep 30, 2024
Description
The NS-VOF assembler was not optimized as the NS assembler. The if conditions on the dof components were added to not compute multiplications that are a priori 0.

Testing
None of the application tests have changed. The computational time gain is about 20% by iteration on the 3D lpbf benchmark case for a simulation of about 300 iterations. I can do it for a complete simulation if you thing it is worth doing it :)

Documentation
No new documentation needed.

Former-commit-id: 51c91aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants