Refactor entry string to tensor functions #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmishgaAlphonius
added
Ready for review
Refactoring
blaisb
approved these changes
Jul 5, 2024
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description The entry_string_to_tensor functions were duplicated; they were in utilities.h and parameters.h. In one case it was templated with spacedim and the other not. This PR merges both uses of the same function in utilities.h. Since these are small functions, they were inlined. Hence, they don't have any explicit instantiation. While doing this, redundant if conditions were noticed in the manifolds.cc, these were replaced by a for loop. Former-commit-id: cc08ca7
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description The entry_string_to_tensor functions were duplicated; they were in utilities.h and parameters.h. In one case it was templated with spacedim and the other not. This PR merges both uses of the same function in utilities.h. Since these are small functions, they were inlined. Hence, they don't have any explicit instantiation. While doing this, redundant if conditions were noticed in the manifolds.cc, these were replaced by a for loop. Former-commit-id: cc08ca7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
entry_string_to_tensorfunctions were duplicated; they were inutilities.handparameters.h. In one case it was templated withspacedimand the other not. This PR merges both uses of the same function inutilities.h. Since these are small functions, they were inlined. Hence, they don't have any explicit instantiation.While doing this, redundant
ifconditions were noticed in themanifolds.cc, these were replaced byforloops.Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: