Fix box refinement with restart #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
blaisb
approved these changes
Jul 2, 2024
oguevremont
approved these changes
Jul 2, 2024
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description Box refinement was applied when restarting simulations, changing the restarting triangulation and leading to undesirable behavior. Solution A boolean stating if the simulation restarts is now checked before applying the box refinement in box_refine_mesh(const bool &restart). Testing A new test simulate the lpbf benchmark case using the extra-extra-coarse mesh with restart and box refinement. Temperature statistics and mass conservation monitoring are the outputted metrics (to track both the change in HT and NS-VOF solvers). Documentation No documentation needs to be modify. Former-commit-id: 64885a4
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description Box refinement was applied when restarting simulations, changing the restarting triangulation and leading to undesirable behavior. Solution A boolean stating if the simulation restarts is now checked before applying the box refinement in box_refine_mesh(const bool &restart). Testing A new test simulate the lpbf benchmark case using the extra-extra-coarse mesh with restart and box refinement. Temperature statistics and mass conservation monitoring are the outputted metrics (to track both the change in HT and NS-VOF solvers). Documentation No documentation needs to be modify. Former-commit-id: 64885a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Box refinement was applied when restarting simulations, changing the restarting triangulation and leading to undesirable behavior.
Solution
A boolean stating if the simulation restarts is now checked before applying the box refinement in box_refine_mesh(const bool &restart).
Testing
A new test simulate the lpbf benchmark case using the extra-extra-coarse mesh with restart and box refinement. Temperature statistics and mass conservation monitoring are the outputted metrics (to track both the change in HT and NS-VOF solvers).
Documentation
No documentation needs to be modify.